chrome/common/extensions/manifest_tests/extension_manifests_platformapp_unittest.cc - Issue 747403002: Ignore insecure parts of CSP in extensions and allow extension to load

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/manifest_tests/extension_manifests_platformapp_unittest.cc

Issue 747403002: Ignore insecure parts of CSP in extensions and allow extension to load (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: small nits Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/extensions/manifest_tests/extension_manifests_contentsecuritypolicy_unittest.cc ('k') | extensions/common/csp_validator.h » ('j') | extensions/common/csp_validator.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/manifest_tests/extension_manifests_platformapp_unittest.cc

diff --git a/chrome/common/extensions/manifest_tests/extension_manifests_platformapp_unittest.cc b/chrome/common/extensions/manifest_tests/extension_manifests_platformapp_unittest.cc

index 296030c09d2cb7ea284e9597184b632f6da1ea04..0bff8f96630a40ee88400cc7a9f165460b6e5af2 100644

--- a/chrome/common/extensions/manifest_tests/extension_manifests_platformapp_unittest.cc

+++ b/chrome/common/extensions/manifest_tests/extension_manifests_platformapp_unittest.cc

@@ -94,9 +94,10 @@ TEST_F(PlatformAppsManifestTest, PlatformAppContentSecurityPolicy) {

std::string()));

// But even whitelisted ones must specify a secure policy.

- LoadAndExpectError(

+ LoadAndExpectWarning(

"init_platform_app_csp_insecure.json",

- errors::kInsecureContentSecurityPolicy);

+ ErrorUtils::FormatErrorMessage(errors::kInvalidCSPInsecureValue,

+ "http://www.google.com", "default-src"));

}

TEST_F(PlatformAppsManifestTest, CertainApisRequirePlatformApps) {