extensions/common/csp_validator.h - Issue 747403002: Ignore insecure parts of CSP in extensions and allow extension to load

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/common/csp_validator.h

Issue 747403002: Ignore insecure parts of CSP in extensions and allow extension to load (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: comments #7 Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/extensions/manifest_tests/extension_manifests_platformapp_unittest.cc ('k') | extensions/common/csp_validator.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/common/csp_validator.h

diff --git a/extensions/common/csp_validator.h b/extensions/common/csp_validator.h

index e7446f6d4fd885f0363d7002f9d780053e3ab7ba..2b6df2d3d2a0395357742d7372dab56cda8ec28b 100644

--- a/extensions/common/csp_validator.h

+++ b/extensions/common/csp_validator.h

@@ -28,8 +28,15 @@ bool ContentSecurityPolicyIsLegal(const std::string& policy);

// However, we found that it broke too many deployed extensions to limit

// 'unsafe-eval' in the script-src directive, so that is allowed as a special

// case for extensions. Platform apps disallow it.

-bool ContentSecurityPolicyIsSecure(

- const std::string& policy, Manifest::Type type);

+//

+// If |sanitized_csp| is not NULL, |policy| minus the insecure values is stored

+// in |sanitized_csp|.

not at google - send to devlin 2014/11/24 18:26:08 Concise is nice: If |sanitized_csp| is non-NULL it

+// If |warnings| is not NULL, any validation errors are appended to |warnings|.

+// Returns whether |policy| meets the minimum security requirements.

+bool ContentSecurityPolicyIsSecure(const std::string& policy,

+ Manifest::Type type,

+ std::string* sanitized_csp,

+ std::vector<InstallWarning>* warnings);

// Checks whether the given |policy| enforces a unique origin sandbox as

// defined by http://www.whatwg.org/specs/web-apps/current-work/multipage/