Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 7474023: [Sync] Prevent switching back to "Sync Everything" view if passphrase needed. (Closed)

Created:
9 years, 4 months ago by Nicolas Zea
Modified:
9 years, 4 months ago
CC:
chromium-reviews, arv (Not doing code reviews)
Visibility:
Public.

Description

[Sync] Prevent switching back to "Sync Everything" view if passphrase needed. BUG=90925 TEST=Sign into account with custom passphrase. Try to click "default view" link. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=94971

Patch Set 1 #

Total comments: 2

Patch Set 2 : Review #

Patch Set 3 : Review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -5 lines) Patch
M chrome/browser/resources/sync_setup_overlay.js View 1 2 4 chunks +13 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Nicolas Zea
Travis and I discussed this and that it doesn't make sense to allow switching back ...
9 years, 4 months ago (2011-07-29 18:31:58 UTC) #1
James Hawkins
http://codereview.chromium.org/7474023/diff/1/chrome/browser/resources/sync_setup_overlay.js File chrome/browser/resources/sync_setup_overlay.js (right): http://codereview.chromium.org/7474023/diff/1/chrome/browser/resources/sync_setup_overlay.js#newcode248 chrome/browser/resources/sync_setup_overlay.js:248: this.animateDisableLink_($('use-default-link'), true, function() { No need to specify this ...
9 years, 4 months ago (2011-07-31 23:50:53 UTC) #2
Nicolas Zea
http://codereview.chromium.org/7474023/diff/1/chrome/browser/resources/sync_setup_overlay.js File chrome/browser/resources/sync_setup_overlay.js (right): http://codereview.chromium.org/7474023/diff/1/chrome/browser/resources/sync_setup_overlay.js#newcode248 chrome/browser/resources/sync_setup_overlay.js:248: this.animateDisableLink_($('use-default-link'), true, function() { On 2011/07/31 23:50:53, James Hawkins ...
9 years, 4 months ago (2011-08-01 17:09:59 UTC) #3
James Hawkins
LGTM, thanks!
9 years, 4 months ago (2011-08-01 18:02:59 UTC) #4
commit-bot: I haz the power
9 years, 4 months ago (2011-08-01 20:35:53 UTC) #5
Change committed as 94971

Powered by Google App Engine
This is Rietveld 408576698