Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Unified Diff: content/renderer/pepper_platform_video_decoder_impl.cc

Issue 7474006: PPB_VideoDecoder_Dev::Initialize is now synchronous! (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: vrk CR update. Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/gpu/gpu_video_decode_accelerator_host.cc ('k') | ppapi/c/dev/ppb_video_decoder_dev.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/pepper_platform_video_decoder_impl.cc
diff --git a/content/renderer/pepper_platform_video_decoder_impl.cc b/content/renderer/pepper_platform_video_decoder_impl.cc
index 29667ffe528864c3536d8169dea8b465cd434d78..39733a9c929068966df814d6ca2478ae9b09f93e 100644
--- a/content/renderer/pepper_platform_video_decoder_impl.cc
+++ b/content/renderer/pepper_platform_video_decoder_impl.cc
@@ -46,7 +46,7 @@ bool PlatformVideoDecoderImpl::Initialize(const std::vector<uint32>& configs) {
// Send IPC message to initialize decoder in GPU process.
decoder_ = channel->CreateVideoDecoder(
command_buffer_route_id_, configs, this);
- return true;
+ return decoder_.get() != NULL;
}
void PlatformVideoDecoderImpl::Decode(const BitstreamBuffer& bitstream_buffer) {
@@ -112,8 +112,7 @@ void PlatformVideoDecoderImpl::PictureReady(const media::Picture& picture) {
}
void PlatformVideoDecoderImpl::NotifyInitializeDone() {
- DCHECK_EQ(RenderThread::current()->message_loop(), MessageLoop::current());
- client_->NotifyInitializeDone();
+ NOTREACHED() << "GpuVideoDecodeAcceleratorHost::Initialize is synchronous!";
}
void PlatformVideoDecoderImpl::NotifyEndOfBitstreamBuffer(
« no previous file with comments | « content/renderer/gpu/gpu_video_decode_accelerator_host.cc ('k') | ppapi/c/dev/ppb_video_decoder_dev.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698