Chromium Code Reviews Chromium Code Reviews
Issue
747363003:
Ignore <rt> children when determining WebVTT text direction (LTR/RTL) (Closed)
DescriptionIgnore <rt> children when determining WebVTT text direction (LTR/RTL)
In the previous implementation of determineTextDirection the
node.localName() == rtTag check would always be false, because the
isTextNode() check would guarantee that localName() was a null String.
Even if it had worked, it would only have skipped the <rt> elements
themselves, not its descendant text nodes.
Rewrite the traversal to skip the children of <rt>.
The two cases added to captions-rtl.vtt would previously detect the
wrong text direction.
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185878
Patch Set 1 #
Messages
Total messages: 6 (2 generated)
|
||||||||||||||||||||||||||||||||||||||||||||||
