Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 747323007: Introduce Stream::flush [1/2 blink] (Closed)

Created:
6 years ago by horo
Modified:
6 years ago
CC:
blink-reviews, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Introduce Stream::flush [1/2 blink] There is no way to flush the buffer in the stream. This cl introduces Stream::flush method. We can flush the buffer in the browser process using this method from blink. We will use this method when we send the data from the ServiceWorker to the browser process progressively. 1/2 blink: https://codereview.chromium.org/747323007/ 2/2 chromium: https://codereview.chromium.org/760823002/ BUG=436424 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186020

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -0 lines) Patch
M Source/core/streams/Stream.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/streams/Stream.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M Source/platform/blob/BlobRegistry.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/platform/blob/BlobRegistry.cpp View 1 chunk +18 lines, -0 lines 0 comments Download
M public/platform/WebBlobRegistry.h View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
horo
tyoshino@ Could you please review?
6 years ago (2014-11-26 02:09:56 UTC) #2
tyoshino (SeeGerritForStatus)
lgtm
6 years ago (2014-11-26 05:59:52 UTC) #3
horo
mkwst@ Could you please review this?
6 years ago (2014-11-26 06:04:14 UTC) #5
Mike West
LGTM.
6 years ago (2014-11-26 08:03:50 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/747323007/1
6 years ago (2014-11-26 08:38:14 UTC) #8
commit-bot: I haz the power
6 years ago (2014-11-26 10:04:34 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=186020

Powered by Google App Engine
This is Rietveld 408576698