Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Issue 747283003: CSS Parser: Implement selector parsing (attributes) [2/3] (Closed)

Created:
6 years ago by Timothy Loh
Modified:
6 years ago
CC:
blink-reviews, blink-reviews-css, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@selectorparsing
Project:
blink
Visibility:
Public.

Description

CSS Parser: Implement selector parsing (attributes) [2/3] This patch continues implementation of CSS selector parsing with css-syntax tokens. This adds support for attribute parsing. http://dev.w3.org/csswg/selectors4/#grammar BUG=330389 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187508

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -2 lines) Patch
M Source/core/css/parser/CSSSelectorParser.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/css/parser/CSSSelectorParser.cpp View 1 2 2 chunks +73 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Timothy Loh
Part 1: https://codereview.chromium.org/790593004/ Part 3: https://codereview.chromium.org/792763003/
6 years ago (2014-12-10 07:30:17 UTC) #2
Timothy Loh
PTAL, I'd like to at least get some of this landed soon, since I have ...
6 years ago (2014-12-19 01:21:25 UTC) #3
alancutter (OOO until 2018)
lgtm
6 years ago (2014-12-19 03:21:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/747283003/40001
6 years ago (2014-12-19 03:30:29 UTC) #6
commit-bot: I haz the power
6 years ago (2014-12-19 05:33:09 UTC) #7
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=187508

Powered by Google App Engine
This is Rietveld 408576698