Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 747283002: Revert of [Telemetry] Move some tests from page_runner_unittest to user_story_runner_unittest. (Closed)

Created:
6 years, 1 month ago by nednguyen
Modified:
6 years, 1 month ago
Reviewers:
dtu, ernstm, tonyg
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of [Telemetry] Move some tests from page_runner_unittest to user_story_runner_unittest. (patchset #1 id:1 of https://codereview.chromium.org/745383002/) Reason for revert: Speculative revert. BUG=435775 Original issue's description: > [Telemetry] Move some tests from page_runner_unittest to user_story_runner_unittest. > > These tests test logic of user_story_runner hence they should be moved to > user_story_runner. In addition, the new tests use fake shared_user_story_state > allows faster cycle time. > > Rename page_runner_unittest --> page_run_end_to_end_tests. > > BUG=434568 > > Committed: https://crrev.com/b709ad84c6002b17b1dfa57f811539f26f51f4cb > Cr-Commit-Position: refs/heads/master@{#305328} TBR=dtu@chromium.org,tonyg@chromium.org,ernstm@chromium.org BUG=434568 Committed: https://crrev.com/e411534db420eb1ef113b947a87303e98badd58a Cr-Commit-Position: refs/heads/master@{#305353}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+676 lines, -673 lines) Patch
D tools/telemetry/telemetry/page/page_run_end_to_end_tests.py View 1 chunk +0 lines, -480 lines 0 comments Download
A tools/telemetry/telemetry/page/page_runner_unittest.py View 1 chunk +668 lines, -0 lines 0 comments Download
M tools/telemetry/telemetry/user_story/user_story_runner.py View 2 chunks +4 lines, -3 lines 0 comments Download
M tools/telemetry/telemetry/user_story/user_story_runner_unittest.py View 6 chunks +4 lines, -190 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
nednguyen
Created Revert of [Telemetry] Move some tests from page_runner_unittest to user_story_runner_unittest.
6 years, 1 month ago (2014-11-22 04:20:13 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/747283002/1
6 years, 1 month ago (2014-11-22 04:22:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/747283002/1
6 years, 1 month ago (2014-11-22 04:30:55 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-22 05:24:37 UTC) #7
commit-bot: I haz the power
6 years, 1 month ago (2014-11-22 05:25:25 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e411534db420eb1ef113b947a87303e98badd58a
Cr-Commit-Position: refs/heads/master@{#305353}

Powered by Google App Engine
This is Rietveld 408576698