Issue 747253002: GYP: prevent code generator from being directly added to All.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 747253002: GYP: prevent code generator from being directly added to All. (Closed)

Created:
6 years, 1 month ago by Nick Bray (chromium)

Modified:
6 years ago

Reviewers:
jamesr, Nico

CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Project:
mojo

Visibility:
Public.

More Reviews

Description

GYP: prevent code generator from being directly added to All. BUG=http://code.google.com/p/chromium/issues/detail?id=435434 R=thakis@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/d80f2e32dbaea2af39e9fb6dc27e7a52a7c77dff

Patch Set 1 #

Patch Set 2 : Uncomment #

Patch Set 3 : Rebase #

Created: 6 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	mojo/public/tools/bindings/mojom_bindings_generator_explicit.gypi	View	1 2	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Nick Bray (chromium)

Queing this up in case someone wants to commit while I am gone. Blocked by: ...

6 years, 1 month ago (2014-11-22 01:04:46 UTC) #2

Nick Bray (chromium)

6 years ago (2014-12-02 23:52:00 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 (id:40001) manually as
d80f2e32dbaea2af39e9fb6dc27e7a52a7c77dff (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages