mojo/services/window_manager/focus_rules.h - Issue 747163002: Port more focus controller unit tests and fix our focus rules.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/services/window_manager/focus_rules.h

Issue 747163002: Port more focus controller unit tests and fix our focus rules. (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Add the window_manager_unittests suite to the list of unittest binaries to run. Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: mojo/services/window_manager/focus_rules.h

diff --git a/mojo/services/window_manager/focus_rules.h b/mojo/services/window_manager/focus_rules.h

index def0b96ed4cd540eeb38198ecb9d1feca04ac598..937876548125db407b825192fef8fe53174c2f1d 100644

--- a/mojo/services/window_manager/focus_rules.h

+++ b/mojo/services/window_manager/focus_rules.h

@@ -16,6 +16,9 @@ class FocusRules {

public:

virtual ~FocusRules() {}

+ // Returns true if the children of |window| can be activated.

+ virtual bool SupportsChildActivation(View* window) const = 0;

// Returns true if |view| is a toplevel view. Whether or not a view

// is considered toplevel is determined by a similar set of rules that

// govern activation and focus. Not all toplevel views are activatable,