Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4411)

Unified Diff: mojo/services/window_manager/basic_focus_rules.h

Issue 747163002: Port more focus controller unit tests and fix our focus rules. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Add the window_manager_unittests suite to the list of unittest binaries to run. Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/services/window_manager/basic_focus_rules.h
diff --git a/mojo/services/window_manager/basic_focus_rules.h b/mojo/services/window_manager/basic_focus_rules.h
index e5db4de4664d52f4f381a73d74b31f4c2bee4f8f..e243ee046dd956b9405829f3f4023b1a9f6d0cde 100644
--- a/mojo/services/window_manager/basic_focus_rules.h
+++ b/mojo/services/window_manager/basic_focus_rules.h
@@ -15,10 +15,6 @@ class View;
//
// This is intended to be a user supplyable, subclassable component passed to
// WindowManagerApp, allowing for the creation of other window managers.
-//
-// TODO(erg): This was a straight move of the minimal focus rules from when
-// WindowManagerApp directly used the wm::FocusController. This implementation
-// is very incomplete. crbug.com/431047
class BasicFocusRules : public FocusRules {
public:
BasicFocusRules(mojo::View* window_container);
@@ -26,6 +22,7 @@ class BasicFocusRules : public FocusRules {
protected:
// Overridden from mojo::FocusRules:
+ bool SupportsChildActivation(mojo::View* view) const override;
bool IsToplevelView(mojo::View* view) const override;
bool CanActivateView(mojo::View* view) const override;
bool CanFocusView(mojo::View* view) const override;
« no previous file with comments | « no previous file | mojo/services/window_manager/basic_focus_rules.cc » ('j') | mojo/services/window_manager/basic_focus_rules.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698