Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Side by Side Diff: PRESUBMIT.py

Issue 747143002: Make gn check //{,mojo}/services/* pass (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | mojo/services/network/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """Top-level presubmit script for Chromium. 5 """Top-level presubmit script for Chromium.
6 6
7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
8 for more details about the presubmit API built into gcl. 8 for more details about the presubmit API built into gcl.
9 """ 9 """
10 10
(...skipping 438 matching lines...) Expand 10 before | Expand all | Expand 10 after
449 '//mojo/application/*', 449 '//mojo/application/*',
450 '//mojo/application_manager/*', 450 '//mojo/application_manager/*',
451 '//mojo/cc/*', 451 '//mojo/cc/*',
452 '//mojo/common/*', 452 '//mojo/common/*',
453 '//mojo/converters/*', 453 '//mojo/converters/*',
454 '//mojo/edk/*', 454 '//mojo/edk/*',
455 '//mojo/environment/*', 455 '//mojo/environment/*',
456 '//mojo/gles2/*', 456 '//mojo/gles2/*',
457 '//mojo/gpu/*', 457 '//mojo/gpu/*',
458 '//mojo/public/*', 458 '//mojo/public/*',
459 '//mojo/services/gles2/*', 459 '//mojo/services/*',
460 '//mojo/services/native_viewport/*',
461 '//mojo/services/public/cpp/view_manager/*',
462 '//mojo/services/view_manager/*',
463 '//mojo/services/window_manager/*',
464 '//mojo/skia/*', 460 '//mojo/skia/*',
465 '//mojo/spy/*', 461 '//mojo/spy/*',
466 '//mojo/tools/*', 462 '//mojo/tools/*',
467 '//mojo/views/*', 463 '//mojo/views/*',
464 '//services/*',
468 ] 465 ]
469 if input_api.platform != 'win32': 466 if input_api.platform != 'win32':
470 KNOWN_PASSING += [ 467 KNOWN_PASSING += [
471 '//sky/*', 468 '//sky/*',
472 ] 469 ]
473 for target_filter in KNOWN_PASSING: 470 for target_filter in KNOWN_PASSING:
474 try: 471 try:
475 input_api.subprocess.check_output(['gn', 'check', relative_out_dir, 472 input_api.subprocess.check_output(['gn', 'check', relative_out_dir,
476 target_filter]) 473 target_filter])
477 except input_api.subprocess.CalledProcessError, error: 474 except input_api.subprocess.CalledProcessError, error:
(...skipping 1138 matching lines...) Expand 10 before | Expand all | Expand 10 after
1616 files = change.LocalPaths() 1613 files = change.LocalPaths()
1617 1614
1618 if not files or all(re.search(r'[\\\/]OWNERS$', f) for f in files): 1615 if not files or all(re.search(r'[\\\/]OWNERS$', f) for f in files):
1619 return {} 1616 return {}
1620 1617
1621 builders = [ 1618 builders = [
1622 'Mojo Linux Try', 1619 'Mojo Linux Try',
1623 ] 1620 ]
1624 1621
1625 return GetDefaultTryConfigs(builders) 1622 return GetDefaultTryConfigs(builders)
OLDNEW
« no previous file with comments | « no previous file | mojo/services/network/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698