Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 747143002: Make gn check //{,mojo}/services/* pass (Closed)

Created:
6 years, 1 month ago by jamesr
Modified:
6 years ago
Reviewers:
hansmuller
CC:
mojo-reviews_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -19 lines) Patch
M PRESUBMIT.py View 1 1 chunk +2 lines, -5 lines 0 comments Download
M mojo/services/network/BUILD.gn View 1 2 2 chunks +4 lines, -0 lines 0 comments Download
M mojo/services/public/cpp/geometry/BUILD.gn View 1 1 chunk +2 lines, -0 lines 0 comments Download
M mojo/services/public/cpp/network/BUILD.gn View 1 2 chunks +10 lines, -9 lines 0 comments Download
M mojo/services/surfaces/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M mojo/services/test_service/BUILD.gn View 1 2 chunks +4 lines, -0 lines 0 comments Download
M services/http_server/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M services/http_server/public/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M services/js/BUILD.gn View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M services/js/modules/clock/BUILD.gn View 1 chunk +6 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jamesr
6 years, 1 month ago (2014-11-21 21:13:16 UTC) #1
jamesr
ping
6 years ago (2014-11-24 20:21:39 UTC) #2
hansmuller
On 2014/11/24 20:21:39, jamesr wrote: > ping LGTM, sorry about the delay.
6 years ago (2014-11-25 00:52:22 UTC) #3
jamesr
6 years ago (2014-11-25 00:57:50 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
55a1e4cce599b310499ee4ea5b413a392aeb6d27 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698