Issue 747143002: Make gn check //{,mojo}/services/* pass

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 747143002: Make gn check //{,mojo}/services/* pass (Closed)

Created:
6 years, 1 month ago by jamesr

Modified:
6 years ago

Reviewers:
hansmuller

CC:
mojo-reviews_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Project:
mojo

Visibility:
Public.

Created: 6 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+37 lines, -19 lines)			Patch
M	PRESUBMIT.py	View	1	1 chunk	+2 lines, -5 lines	0 comments	Download
M	mojo/services/network/BUILD.gn	View	1 2	2 chunks	+4 lines, -0 lines	0 comments	Download
M	mojo/services/public/cpp/geometry/BUILD.gn	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	mojo/services/public/cpp/network/BUILD.gn	View	1	2 chunks	+10 lines, -9 lines	0 comments	Download
M	mojo/services/surfaces/BUILD.gn	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	mojo/services/test_service/BUILD.gn	View	1	2 chunks	+4 lines, -0 lines	0 comments	Download
M	services/http_server/BUILD.gn	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	services/http_server/public/BUILD.gn	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	services/js/BUILD.gn	View	1 2	1 chunk	+4 lines, -0 lines	0 comments	Download
M	services/js/modules/clock/BUILD.gn	View		1 chunk	+6 lines, -5 lines	0 comments	Download

Total messages: 4 (0 generated)

hansmuller

On 2014/11/24 20:21:39, jamesr wrote: > ping LGTM, sorry about the delay.

6 years ago (2014-11-25 00:52:22 UTC) #3

jamesr

6 years ago (2014-11-25 00:57:50 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 (id:40001) manually as
55a1e4cce599b310499ee4ea5b413a392aeb6d27 (presubmit successful).