Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(575)

Unified Diff: content/browser/media/media_internals.cc

Issue 747093002: Modify names of PipelineStatus histograms (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/media/media_internals.cc
diff --git a/content/browser/media/media_internals.cc b/content/browser/media/media_internals.cc
index b16b66be60af3b9f9c5614eb911e7e52775d1940..571337cb839f4ac75ccc7872e04609c7c3330028 100644
--- a/content/browser/media/media_internals.cc
+++ b/content/browser/media/media_internals.cc
@@ -298,34 +298,34 @@ void MediaInternals::MediaInternalsUMAHandler::ReportUMAForPipelineStatus(
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
if (player_info.has_video && player_info.has_audio) {
if (player_info.video_codec_name == "vp8") {
- UMA_HISTOGRAM_ENUMERATION("Media.PipelineStatus.AudioVideo.VP8",
+ UMA_HISTOGRAM_ENUMERATION("Media.PipelineStatus.AudioVideo.VP8.SW",
player_info.last_pipeline_status,
media::PIPELINE_STATUS_MAX + 1);
} else if (player_info.video_codec_name == "vp9") {
- UMA_HISTOGRAM_ENUMERATION("Media.PipelineStatus.AudioVideo.VP9",
+ UMA_HISTOGRAM_ENUMERATION("Media.PipelineStatus.AudioVideo.VP9.SW",
player_info.last_pipeline_status,
media::PIPELINE_STATUS_MAX + 1);
} else if (player_info.video_codec_name == "h264") {
if (player_info.video_decoder == media::GpuVideoDecoder::kDecoderName) {
- UMA_HISTOGRAM_ENUMERATION("Media.PipelineStatus.AudioVideo.HW.H264",
+ UMA_HISTOGRAM_ENUMERATION("Media.PipelineStatus.AudioVideo.H264.HW",
player_info.last_pipeline_status,
media::PIPELINE_STATUS_MAX + 1);
} else {
- UMA_HISTOGRAM_ENUMERATION("Media.PipelineStatus.AudioVideo.SW.H264",
+ UMA_HISTOGRAM_ENUMERATION("Media.PipelineStatus.AudioVideo.H264.SW",
player_info.last_pipeline_status,
media::PIPELINE_STATUS_MAX + 1);
}
} else {
- UMA_HISTOGRAM_ENUMERATION("Media.PipelineStatus.AudioVideo",
+ UMA_HISTOGRAM_ENUMERATION("Media.PipelineStatus.AudioVideo.Others",
DaleCurtis 2014/11/21 20:43:09 Other?
player_info.last_pipeline_status,
media::PIPELINE_STATUS_MAX + 1);
}
} else if (player_info.has_audio) {
- UMA_HISTOGRAM_ENUMERATION("Media.PipelineStatus.Audio",
+ UMA_HISTOGRAM_ENUMERATION("Media.PipelineStatus.AudioOnly",
player_info.last_pipeline_status,
media::PIPELINE_STATUS_MAX + 1);
} else if (player_info.has_video) {
- UMA_HISTOGRAM_ENUMERATION("Media.PipelineStatus.Video",
+ UMA_HISTOGRAM_ENUMERATION("Media.PipelineStatus.VideoOnly",
player_info.last_pipeline_status,
media::PIPELINE_STATUS_MAX + 1);
} else {
« no previous file with comments | « no previous file | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698