Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 747043002: Referrer Policy: Introduce "Origin When Cross-Origin" [2/3] (Closed)

Created:
6 years, 1 month ago by Mike West
Modified:
6 years, 1 month ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@urlrequest
Project:
chromium
Visibility:
Public.

Description

Referrer Policy: Introduce "Origin When Cross-Origin" [2/3] As specified at [1], this patch wires the Blink-side of the referrer policy to the proper policy in the network stack. [1/3]: Blink - https://codereview.chromium.org/736233004/ [2/3]: This patch. [3/3]: Blink - https://codereview.chromium.org/747903003 [1]: https://w3c.github.io/webappsec/specs/referrer-policy/#origin-when-cross-origin BUG=309551 Committed: https://crrev.com/c82d2a7642d7659897d0e59a92b0ceb3bbfbc594 Cr-Commit-Position: refs/heads/master@{#305370}

Patch Set 1 #

Patch Set 2 : Test. #

Total comments: 2

Patch Set 3 : clang-format #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -0 lines) Patch
M chrome/browser/referrer_policy_browsertest.cc View 1 2 2 chunks +25 lines, -0 lines 0 comments Download
M content/browser/loader/resource_dispatcher_host_impl.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Mike West
2/3. WDYT?
6 years, 1 month ago (2014-11-21 15:18:11 UTC) #2
jochen (gone - plz use gerrit)
lgtm https://codereview.chromium.org/747043002/diff/20001/chrome/browser/referrer_policy_browsertest.cc File chrome/browser/referrer_policy_browsertest.cc (right): https://codereview.chromium.org/747043002/diff/20001/chrome/browser/referrer_policy_browsertest.cc#newcode590 chrome/browser/referrer_policy_browsertest.cc:590: HttpLeftClickHTTPSRedirectToHTTPOriginWhenCrossOrigin) { is that clang-formatted?
6 years, 1 month ago (2014-11-21 16:25:26 UTC) #3
Mike West
Thanks! https://codereview.chromium.org/747043002/diff/20001/chrome/browser/referrer_policy_browsertest.cc File chrome/browser/referrer_policy_browsertest.cc (right): https://codereview.chromium.org/747043002/diff/20001/chrome/browser/referrer_policy_browsertest.cc#newcode590 chrome/browser/referrer_policy_browsertest.cc:590: HttpLeftClickHTTPSRedirectToHTTPOriginWhenCrossOrigin) { On 2014/11/21 16:25:26, jochen (slow) wrote: ...
6 years, 1 month ago (2014-11-21 16:29:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/747043002/40001
6 years, 1 month ago (2014-11-22 18:15:52 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years, 1 month ago (2014-11-22 19:07:58 UTC) #7
commit-bot: I haz the power
6 years, 1 month ago (2014-11-22 19:08:35 UTC) #8
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/c82d2a7642d7659897d0e59a92b0ceb3bbfbc594
Cr-Commit-Position: refs/heads/master@{#305370}

Powered by Google App Engine
This is Rietveld 408576698