Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 747033005: add endRecordingAsDrawable (Closed)

Created:
6 years, 1 month ago by reed2
Modified:
6 years ago
Reviewers:
mtklein, robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

add endRecordingAsDrawable patch from issue 750723002 at patchset 20001 (http://crrev.com/750723002#ps20001) BUG=skia:

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : test_gatherpixelrefsandrects is failing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+191 lines, -67 lines) Patch
M include/core/SkPicture.h View 2 chunks +2 lines, -1 line 0 comments Download
M include/core/SkPictureRecorder.h View 3 chunks +4 lines, -1 line 0 comments Download
M samplecode/SampleArc.cpp View 1 6 chunks +18 lines, -10 lines 0 comments Download
M src/core/SkCanvasDrawable.h View 3 chunks +3 lines, -6 lines 0 comments Download
M src/core/SkCanvasDrawable.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M src/core/SkPicture.cpp View 1 3 chunks +4 lines, -4 lines 0 comments Download
M src/core/SkPictureRecorder.cpp View 1 2 3 4 4 chunks +76 lines, -1 line 0 comments Download
M src/core/SkRecord.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/core/SkRecordDraw.h View 5 chunks +9 lines, -3 lines 0 comments Download
M src/core/SkRecordDraw.cpp View 4 chunks +11 lines, -4 lines 0 comments Download
M src/core/SkRecorder.h View 3 chunks +23 lines, -3 lines 0 comments Download
M src/core/SkRecorder.cpp View 3 chunks +28 lines, -21 lines 0 comments Download
M src/gpu/GrRecordReplaceDraw.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/RecordDrawTest.cpp View 1 5 chunks +5 lines, -5 lines 0 comments Download
M tools/DumpRecord.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
reed2
6 years, 1 month ago (2014-11-22 04:40:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/747033005/20001
6 years, 1 month ago (2014-11-22 04:41:16 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 1 month ago (2014-11-22 04:41:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/747033005/40001
6 years, 1 month ago (2014-11-22 04:45:16 UTC) #8
commit-bot: I haz the power
6 years, 1 month ago (2014-11-22 04:45:17 UTC) #9 
Note for Reviewers:
The CQ is waiting for an approval.
If you believe that the CL is not ready yet, or if you would like to L-G-T-M
with comments then please uncheck the CQ checkbox.

Waiting for LGTM from valid reviewer(s) till 2014-11-22 10:45 UTC

Powered by Google App Engine
This is Rietveld 408576698