Various optimizations to reduce the number of temporary allocations.

chrome/browser/themes/theme_properties.cc

Index: chrome/browser/themes/theme_properties.cc
diff --git a/chrome/browser/themes/theme_properties.cc b/chrome/browser/themes/theme_properties.cc
index caafb1cd89a7ad3beb8bbda1cc73ddce38aa44f8..bc206998116c961135328d86060322ccbeb88952 100644
--- a/chrome/browser/themes/theme_properties.cc
+++ b/chrome/browser/themes/theme_properties.cc
@@ -203,9 +203,7 @@ std::string ThemeProperties::TilingToString(int tiling) {
 // static
 bool ThemeProperties::IsThemeableImage(int id) {
   // TODO(pkotwicz): Cache results to improve lookup speed.
-  std::set<int> themeable_idrs;
-  BrowserThemePack::GetThemeableImageIDRs(&themeable_idrs);
-  return themeable_idrs.find(id) != themeable_idrs.end();
+  return BrowserThemePack::FindThemeableImageIDRs(id);

[viettrungluu, 2014/12/01 18:59:02]

I'd call this "IsThemeableImageIDR()", rather than "Find...()".

Note that this is, AFAICT (i.e., according to code search, which may miss uses
in Windows-only code and other places), the only use of GetThemeableImageIDRs().

I'd also comment that GetThemeableImageIDRs() creating a new set each time is
crazy, since the set is the same every time. (E.g., it could just as easily
return a const reference/pointer to a singleton set.)

[Georges Khalil, 2014/12/03 19:10:08]

Done.

 }
 
 // static