chrome/browser/themes/browser_theme_pack.h - Issue 747013003: Various optimizations to reduce the number of temporary allocations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/themes/browser_theme_pack.h

Issue 747013003: Various optimizations to reduce the number of temporary allocations. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added back calls to c_str that were removed by mistake. Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/font_settings/font_settings_api.cc ('k') | chrome/browser/themes/browser_theme_pack.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/themes/browser_theme_pack.h

diff --git a/chrome/browser/themes/browser_theme_pack.h b/chrome/browser/themes/browser_theme_pack.h

index effba56c166599aab5ef5163127d2d172eaf5c25..6d236b54b06b4cdf3aaf445b8e2ed5c03aa5a308 100644

--- a/chrome/browser/themes/browser_theme_pack.h

+++ b/chrome/browser/themes/browser_theme_pack.h

@@ -67,9 +67,9 @@ class BrowserThemePack : public CustomThemeSupplier {

static scoped_refptr<BrowserThemePack> BuildFromDataPack(

const base::FilePath& path, const std::string& expected_id);

- // Returns the set of image IDRs which can be overwritten by a user provided

- // theme.

- static void GetThemeableImageIDRs(std::set<int>* result);

+ // Returns whether the specified identifier is one of the images we persist

+ // in the data pack.

+ static bool IsPersistentImageID(int id);

// Builds a data pack on disk at |path| for future quick loading by

// BuildFromDataPack(). Often (but not always) called from the file thread;

« no previous file with comments | « chrome/browser/extensions/api/font_settings/font_settings_api.cc ('k') | chrome/browser/themes/browser_theme_pack.cc » ('j') | no next file with comments »