Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Unified Diff: webkit/fileapi/native_file_util_unittest.cc

Issue 7470037: [Refactor] to rename and re-layer the file_util stack layers. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Rebased. Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webkit/fileapi/native_file_util_unittest.cc
diff --git a/webkit/fileapi/file_system_file_util_unittest.cc b/webkit/fileapi/native_file_util_unittest.cc
similarity index 88%
rename from webkit/fileapi/file_system_file_util_unittest.cc
rename to webkit/fileapi/native_file_util_unittest.cc
index 459a19c489e6e7f4e31e49eee1b917cb1e3c75d1..7af5b858f90f74fb22d60a3f92e770b2cc50e42c 100644
--- a/webkit/fileapi/file_system_file_util_unittest.cc
+++ b/webkit/fileapi/native_file_util_unittest.cc
@@ -11,7 +11,8 @@
#include "webkit/fileapi/file_system_context.h"
#include "webkit/fileapi/file_system_operation_context.h"
#include "webkit/fileapi/file_system_test_helper.h"
-#include "webkit/fileapi/obfuscated_file_system_file_util.h"
+#include "webkit/fileapi/native_file_util.h"
+#include "webkit/fileapi/obfuscated_file_util.h"
using namespace fileapi;
@@ -46,17 +47,17 @@ const CopyMoveTestCaseRecord kCopyMoveTestCases[] = {
} // namespace (anonymous)
-// This is not yet a full unit test for FileSystemFileUtil. TODO(ericu): Adapt
+// This is not yet a full unit test for NativeFileUtil. TODO(ericu): Adapt
// the other subclasses' unit tests, as mentioned in the comments in
-// ObfuscatedFileSystemFileUtil's unit test.
+// ObfuscatedFileUtil's unit test.
ericu 2011/08/25 17:58:05 This file should have stayed as file_system_file_u
Dai Mikurube (NOT FULLTIME) 2011/08/26 05:10:59 Ah, sure. Done.
// Currently this is just a test of cross-filesystem copy and move, which
-// actually exercises subclasses of FileSystemFileUtil as well as the class
+// actually exercises subclasses of NativeFileUtil as well as the class
// itself. We currently only test copies between obfuscated filesystems.
// TODO(ericu): Add a test for copying between obfuscated and local filesystems,
// and between different local filesystems.
-class FileSystemFileUtilTest : public testing::Test {
+class NativeFileUtilTest : public testing::Test {
public:
- FileSystemFileUtilTest() {
+ NativeFileUtilTest() {
}
void SetUp() {
@@ -77,9 +78,8 @@ class FileSystemFileUtilTest : public testing::Test {
bool copy) {
ScopedTempDir base_dir;
ASSERT_TRUE(base_dir.CreateUniqueTempDir());
- scoped_refptr<ObfuscatedFileSystemFileUtil> file_util(
- new ObfuscatedFileSystemFileUtil(base_dir.path(),
- new FileSystemFileUtil()));
+ scoped_refptr<ObfuscatedFileUtil> file_util(
+ new ObfuscatedFileUtil(base_dir.path(), new NativeFileUtil()));
FileSystemTestOriginHelper src_helper(src_origin, src_type);
src_helper.SetUp(base_dir.path(),
false, // incognito
@@ -115,8 +115,8 @@ class FileSystemFileUtilTest : public testing::Test {
FileSystemContext* file_system_context = dest_helper.file_system_context();
scoped_ptr<FileSystemOperationContext> copy_context(
new FileSystemOperationContext(file_system_context, NULL));
- copy_context->set_src_file_system_file_util(file_util);
- copy_context->set_dest_file_system_file_util(file_util);
+ copy_context->set_src_file_util(file_util);
+ copy_context->set_dest_file_util(file_util);
copy_context->set_src_origin_url(src_helper.origin());
copy_context->set_dest_origin_url(dest_helper.origin());
copy_context->set_src_type(src_helper.type());
@@ -173,10 +173,10 @@ class FileSystemFileUtilTest : public testing::Test {
}
private:
- DISALLOW_COPY_AND_ASSIGN(FileSystemFileUtilTest);
+ DISALLOW_COPY_AND_ASSIGN(NativeFileUtilTest);
};
-TEST_F(FileSystemFileUtilTest, TestCrossFileSystemCopyDifferentOrigins) {
+TEST_F(NativeFileUtilTest, TestCrossFileSystemCopyDifferentOrigins) {
GURL src_origin("http://www.example.com");
fileapi::FileSystemType type = kFileSystemTypePersistent;
GURL dest_origin("http://www.not.the.same.domain.com");
@@ -184,7 +184,7 @@ TEST_F(FileSystemFileUtilTest, TestCrossFileSystemCopyDifferentOrigins) {
TestCrossFileSystemCopyMoveHelper(src_origin, type, dest_origin, type, true);
}
-TEST_F(FileSystemFileUtilTest, TestCrossFileSystemCopySameOrigin) {
+TEST_F(NativeFileUtilTest, TestCrossFileSystemCopySameOrigin) {
GURL origin("http://www.example.com");
fileapi::FileSystemType src_type = kFileSystemTypePersistent;
fileapi::FileSystemType dest_type = kFileSystemTypeTemporary;
@@ -192,7 +192,7 @@ TEST_F(FileSystemFileUtilTest, TestCrossFileSystemCopySameOrigin) {
TestCrossFileSystemCopyMoveHelper(origin, src_type, origin, dest_type, true);
}
-TEST_F(FileSystemFileUtilTest, TestCrossFileSystemMoveDifferentOrigins) {
+TEST_F(NativeFileUtilTest, TestCrossFileSystemMoveDifferentOrigins) {
GURL src_origin("http://www.example.com");
fileapi::FileSystemType type = kFileSystemTypePersistent;
GURL dest_origin("http://www.not.the.same.domain.com");
@@ -200,7 +200,7 @@ TEST_F(FileSystemFileUtilTest, TestCrossFileSystemMoveDifferentOrigins) {
TestCrossFileSystemCopyMoveHelper(src_origin, type, dest_origin, type, false);
}
-TEST_F(FileSystemFileUtilTest, TestCrossFileSystemMoveSameOrigin) {
+TEST_F(NativeFileUtilTest, TestCrossFileSystemMoveSameOrigin) {
GURL origin("http://www.example.com");
fileapi::FileSystemType src_type = kFileSystemTypePersistent;
fileapi::FileSystemType dest_type = kFileSystemTypeTemporary;

Powered by Google App Engine
This is Rietveld 408576698