Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(2)

Issue 7470036: Prevent Google Mail Checker from scheduling more than one concurrent request. (Closed)

Created:
7 years, 9 months ago by Mihai Parparita -not on Chrome
Modified:
7 years, 9 months ago
Reviewers:
Matt Perry
CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews
Visibility:
Public.

Description

Prevent Google Mail Checker from scheduling more than one concurrent request. In the case of failures (simulated by blackholing mail.google.com in /etc/hosts, getInboxCount was calling onError in both the onreadystatechange and onerror handlers). Prevent this in two ways: by only invoking the callback once and by making scheduleRequest cancel any already-scheduled requests. BUG=88514 TEST=no R=mpcomplete@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=94342

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
chrome/common/extensions/docs/examples/extensions/gmail.zip View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/common/extensions/docs/examples/extensions/gmail/background.html View 3 chunks +8 lines, -2 lines 0 comments Download
M chrome/common/extensions/docs/samples.json View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Mihai Parparita -not on Chrome
7 years, 9 months ago (2011-07-27 01:53:15 UTC) #1
Matt Perry
7 years, 9 months ago (2011-07-27 18:03:51 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698