Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issue 7470034: Enabled PyAuto on the Mac 10.6 bots. (Closed)

Created:
9 years, 5 months ago by Nick Bray
Modified:
9 years, 5 months ago
Reviewers:
Mark Seaborn
CC:
native-client-reviews_googlegroups.com
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fixes #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M SConstruct View 1 1 chunk +8 lines, -2 lines 3 comments Download

Messages

Total messages: 4 (0 generated)
Nick Bray
9 years, 5 months ago (2011-07-26 23:30:01 UTC) #1
Mark Seaborn
http://codereview.chromium.org/7470034/diff/1/SConstruct File SConstruct (right): http://codereview.chromium.org/7470034/diff/1/SConstruct#newcode1294 SConstruct:1294: # However, Macs will have 32-bit versions of Python ...
9 years, 5 months ago (2011-07-26 23:38:47 UTC) #2
Nick Bray
PTAL
9 years, 5 months ago (2011-07-27 00:07:37 UTC) #3
Mark Seaborn
9 years, 5 months ago (2011-07-27 00:44:26 UTC) #4
LGTM with fixes

http://codereview.chromium.org/7470034/diff/3001/SConstruct
File SConstruct (right):

http://codereview.chromium.org/7470034/diff/3001/SConstruct#newcode1294
SConstruct:1294: # However, our Mac bots will have 32-bit versions of Python
2.5, even if they
Please spell out the cases:
 * Mac OS X 10.5 bots have 32-bit Python 2.5 installed as part of the OS.
 * Mac OS X 10.6 bots have had 32-bit Python 2.5 manually installed.

http://codereview.chromium.org/7470034/diff/3001/SConstruct#newcode1296
SConstruct:1296: # TODO(ncbray): check the architechture of the Python that we
plan to run,
sp: architecture

http://codereview.chromium.org/7470034/diff/3001/SConstruct#newcode1297
SConstruct:1297: # rather than the architechture of Python currently running.
ditto

Powered by Google App Engine
This is Rietveld 408576698