Issue 746953002: Move XMLHttpRequest#responseText to a getter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 746953002: Move XMLHttpRequest#responseText to a getter (Closed)

Created:
6 years, 1 month ago by abarth-chromium

Modified:
6 years, 1 month ago

Reviewers:
esprehn

CC:
esprehn, mojo-reviews_chromium.org, ojan

Base URL:
git@github.com:domokit/mojo.git@master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Move XMLHttpRequest#responseText to a getter Moving this property to a getter lets the implementation of the object change the value but prevents clients of the API from changing the value, which is the expected behavior. R=esprehn@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/3e0193a1fce142937ede5c19bfb227c14c6e1a01

Patch Set 1 #

Total comments: 1

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -2 lines)			Patch
	M	sky/framework/xmlhttprequest.sky	View		3 chunks	+6 lines, -2 lines	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

esprehn

lgtm, but I think you want empty string https://codereview.chromium.org/746953002/diff/1/sky/framework/xmlhttprequest.sky File sky/framework/xmlhttprequest.sky (right): https://codereview.chromium.org/746953002/diff/1/sky/framework/xmlhttprequest.sky#newcode19 sky/framework/xmlhttprequest.sky:19: this.responseText ...

6 years, 1 month ago (2014-11-21 08:08:28 UTC) #2

abarth-chromium

6 years, 1 month ago (2014-11-21 08:09:54 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
3e0193a1fce142937ede5c19bfb227c14c6e1a01 (presubmit successful).

Expand Messages | Collapse Messages