Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 74693002: . (Closed)

Created:
7 years, 1 month ago by Nico
Modified:
7 years, 1 month ago
Reviewers:
bshe
CC:
chromium-reviews, kalyank, sadrul, ben+ash_chromium.org, tfarina
Visibility:
Public.

Description

Revert r235502 "Add a full screen virtual keyboard to virtual keyboard root window" Test has been failing on Win8 Aura since it landed. [ RUN ] VirtualKeyboardWindowControllerTest.VirtualKeyboardWindowTest [1816:612:1115/193527:1412105:FATAL:display_manager.cc(571)] Check failed: 1u == updated_display_info_list.size() (1 vs. 2)Multiple display test does not work on Win8 bots. Please skip (don't disable) the test using SupportsMultipleDisplays() Backtrace: base::debug::StackTrace::StackTrace [0x6C8EBBF1+33] logging::LogMessage::~LogMessage [0x6C71D2FE+94] ash::internal::DisplayManager::UpdateDisplays [0x5BA229F5+293] ash::internal::DisplayManager::OnNativeDisplaysChanged [0x5BA22173+2723] ash::internal::DisplayManager::InitFromCommandLine [0x5BA1E281+817] ash::Shell::Init [0x5B7628A2+210] ash::Shell::CreateInstance [0x5B75C8D9+361] ash::test::AshTestHelper::SetUp [0x01782E29+281] ash::test::AshTestBase::SetUp [0x017753AC+332] ash::test::VirtualKeyboardWindowControllerTest::SetUp [0x016A57D7+247] testing::internal::HandleExceptionsInMethodIfSupported<testing::Test,void> [0x0174E3BF+319] testing::Test::Run [0x01738DDB+107] testing::TestInfo::Run [0x017397ED+221] testing::TestCase::Run [0x01739F9F+239] testing::internal::UnitTestImpl::RunAllTests [0x017408ED+701] testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl,bool> [0x0174EFE7+327] testing::UnitTest::Run [0x0173F150+192] base::TestSuite::Run [0x0172DD00+240] main [0x01647767+103] __tmainCRTStartup [0x018B870F+447] (f:\dd\vctools\crt_bld\self_x86\crt\src\crtexe.c:555) mainCRTStartup [0x018B853F+15] (f:\dd\vctools\crt_bld\self_x86\crt\src\crtexe.c:371) BaseThreadInitThunk [0x750D8543+14] RtlInitializeExceptionChain [0x775DAC69+133] RtlInitializeExceptionChain [0x775DAC3C+88] http://build.chromium.org/p/chromium.win/builders/Win8%20Aura/builds/12680/steps/ash_unittests/logs/stdio BUG=310331 TBR=bshe@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=235520

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -276 lines) Patch
M ash/ash.gyp View 4 chunks +2 lines, -5 lines 0 comments Download
M ash/display/display_controller.h View 1 chunk +0 lines, -5 lines 0 comments Download
M ash/display/virtual_keyboard_window_controller.h View 3 chunks +0 lines, -16 lines 0 comments Download
M ash/display/virtual_keyboard_window_controller.cc View 3 chunks +0 lines, -8 lines 0 comments Download
D ash/display/virtual_keyboard_window_controller_unittest.cc View 1 chunk +0 lines, -64 lines 0 comments Download
A + ash/keyboard_controller_proxy_stub.h View 2 chunks +6 lines, -12 lines 0 comments Download
A + ash/keyboard_controller_proxy_stub.cc View 2 chunks +1 line, -8 lines 0 comments Download
M ash/root_window_controller.cc View 4 chunks +10 lines, -17 lines 0 comments Download
M ash/root_window_controller_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/shell.h View 3 chunks +2 lines, -9 lines 0 comments Download
M ash/shell.cc View 6 chunks +9 lines, -22 lines 0 comments Download
D ash/shell/keyboard_controller_proxy_stub.h View 1 chunk +0 lines, -39 lines 0 comments Download
D ash/shell/keyboard_controller_proxy_stub.cc View 1 chunk +0 lines, -42 lines 0 comments Download
M ash/shell/shell_delegate_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/test/test_shell_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/chrome_shell_delegate_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/ash/chrome_browser_main_extra_parts_ash.cc View 1 chunk +3 lines, -6 lines 0 comments Download
M ui/keyboard/keyboard_controller.cc View 3 chunks +4 lines, -5 lines 0 comments Download
M ui/keyboard/keyboard_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/keyboard/keyboard_switches.h View 1 chunk +2 lines, -3 lines 0 comments Download
M ui/keyboard/keyboard_switches.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/keyboard/keyboard_util.h View 1 chunk +0 lines, -3 lines 0 comments Download
M ui/keyboard/keyboard_util.cc View 1 chunk +2 lines, -5 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Nico
7 years, 1 month ago (2013-11-17 05:51:21 UTC) #1
Message was sent while issue was closed.
Committed patchset #1 manually as r235520.

Powered by Google App Engine
This is Rietveld 408576698