Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(481)

Issue 746743003: Ignore tests that fail on nosnap apparently for infa reasons. (Closed)

Created:
6 years ago by Dmitry Lomov (no reviews)
Modified:
6 years ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Project:
v8
Visibility:
Public.

Description

Ignore tests that fail on nosnap apparently for infa reasons. TBR=arv@chromium.org BUG=v8:3744 LOG=N NOTRY=true Committed: https://chromium.googlesource.com/v8/v8/+/90a297a8e02579672691bf268be2c62fc1b6edcc

Patch Set 1 #

Patch Set 2 : fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M test/message/message.status View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
Dmitry Lomov (no reviews)
6 years ago (2014-12-08 18:38:22 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/746743003/20001
6 years ago (2014-12-08 18:39:01 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years ago (2014-12-08 18:39:02 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/746743003/20001
6 years ago (2014-12-08 18:39:31 UTC) #7
Dmitry Lomov (no reviews)
Committed patchset #2 (id:20001) manually as 90a297a8e02579672691bf268be2c62fc1b6edcc (tree was closed).
6 years ago (2014-12-08 18:41:50 UTC) #9
arv (Not doing code reviews)
LGTM What does "info reasonse" mean?
6 years ago (2014-12-08 19:13:08 UTC) #10
adamk
On 2014/12/08 19:13:08, arv wrote: > LGTM > > What does "info reasonse" mean? Guessing ...
6 years ago (2014-12-08 19:15:35 UTC) #11
Dmitry Lomov (no reviews)
On 2014/12/08 19:15:35, adamk wrote: > On 2014/12/08 19:13:08, arv wrote: > > LGTM > ...
6 years ago (2014-12-08 19:16:11 UTC) #12
Michael Achenbach
6 years ago (2014-12-08 20:58:58 UTC) #13
Message was sent while issue was closed.
On 2014/12/08 19:16:11, Dmitry Lomov (chromium) wrote:
> On 2014/12/08 19:15:35, adamk wrote:
> > On 2014/12/08 19:13:08, arv wrote:
> > > LGTM
> > > 
> > > What does "info reasonse" mean?
> > 
> > Guessing he meant "infra reasons", as in "infrastructure".
> 
> Yup, sorry, it does not repro locally under Linux with nosnap

Be aware of v8_optimized_debug=1 that's used on the bots. You need to specify
that when compiling debug. When compiling optdebug it might get overwritten.

Powered by Google App Engine
This is Rietveld 408576698