Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2464)

Unified Diff: remoting/host/policy_hack/policy_watcher.h

Issue 746723002: Revert of Reporting of policy errors via host-offline-reason: part 1 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/host/policy_hack/mock_policy_callback.cc ('k') | remoting/host/policy_hack/policy_watcher.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/host/policy_hack/policy_watcher.h
diff --git a/remoting/host/policy_hack/policy_watcher.h b/remoting/host/policy_hack/policy_watcher.h
index dbbfd2310fe8104d7541da7b41b61750343ad4a1..109a110370b6a2fa265320cfcd138ddf086c8e14 100644
--- a/remoting/host/policy_hack/policy_watcher.h
+++ b/remoting/host/policy_hack/policy_watcher.h
@@ -26,33 +26,17 @@
public:
// Called first with all policies, and subsequently with any changed policies.
typedef base::Callback<void(scoped_ptr<base::DictionaryValue>)>
- PolicyUpdatedCallback;
-
- // Called after detecting malformed policies.
- typedef base::Callback<void()> PolicyErrorCallback;
+ PolicyCallback;
explicit PolicyWatcher(
scoped_refptr<base::SingleThreadTaskRunner> task_runner);
virtual ~PolicyWatcher();
- // This guarantees that the |policy_updated_callback| is called at least once
- // with the current policies. After that, |policy_updated_callback| will be
- // called whenever a change to any policy is detected. It will then be called
- // only with the changed policies.
- //
- // |policy_error_callback| will be called when malformed policies are detected
- // (i.e. wrong type of policy value, or unparseable files under
- // /etc/opt/chrome/policies/managed).
- // When called, the |policy_error_callback| is responsible for mitigating the
- // security risk of running with incorrectly formulated policies (by either
- // shutting down or locking down the host).
- // After calling |policy_error_callback| PolicyWatcher will continue watching
- // for policy changes and will call |policy_updated_callback| when the error
- // is recovered from and may call |policy_error_callback| when new errors are
- // found.
- virtual void StartWatching(
- const PolicyUpdatedCallback& policy_updated_callback,
- const PolicyErrorCallback& policy_error_callback);
+ // This guarantees that the |policy_callback| is called at least once with
+ // the current policies. After that, |policy_callback| will be called
+ // whenever a change to any policy is detected. It will then be called only
+ // with the changed policies.
+ virtual void StartWatching(const PolicyCallback& policy_callback);
// Should be called after StartWatching() before the object is deleted. Calls
// should wait for |stopped_callback| to be called before deleting it.
@@ -118,15 +102,6 @@
// relevant policies.
void UpdatePolicies(const base::DictionaryValue* new_policy);
- // Signals policy error to the registered |PolicyErrorCallback|.
- void SignalPolicyError();
-
- // Called whenever a transient error occurs during reading of policy files.
- // This will increment a counter, and will trigger a call to
- // SignalPolicyError() only after a threshold count is reached.
- // The counter is reset whenever policy has been successfully read.
- void SignalTransientPolicyError();
-
// Used for time-based reloads in case something goes wrong with the
// notification system.
void ScheduleFallbackReloadTask();
@@ -139,9 +114,7 @@
void StopWatchingOnPolicyWatcherThread();
scoped_refptr<base::SingleThreadTaskRunner> task_runner_;
- PolicyUpdatedCallback policy_updated_callback_;
- PolicyErrorCallback policy_error_callback_;
- int transient_policy_error_retry_counter_;
+ PolicyCallback policy_callback_;
scoped_ptr<base::DictionaryValue> old_policies_;
scoped_ptr<base::DictionaryValue> default_values_;
« no previous file with comments | « remoting/host/policy_hack/mock_policy_callback.cc ('k') | remoting/host/policy_hack/policy_watcher.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698