Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 746723002: Revert of Reporting of policy errors via host-offline-reason: part 1 (Closed)

Created:
6 years, 1 month ago by Łukasz Anforowicz
Modified:
6 years, 1 month ago
Reviewers:
Lambros, kelvinp
CC:
chromium-reviews, chromoting-reviews_chromium.org, rmsousa
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Reporting of policy errors via host-offline-reason: part 1 (patchset #6 id:100001 of https://codereview.chromium.org/722743003/) Reason for revert: The reason for reverting is: Reason for reverting - failures in memory test: remoting did not complete failed 1 stdio Me2MeNativeMessagingHostTest.UpdateDaemonConfigInvalidConfig Original issue's description: > Reporting of policy errors via host-offline-reason: part 1 > > PolicyWatcher.OnPolicyError callback and implementation. > - This new callback enables HostProcess to react to policy errors by > calling ShutdownHost. > - PolicyWatcher on Linux calls this callback when detecting malformed > policy files (with retries mechanism to avoid firing this for > transient file reading problems) > > BUG=427512 410050 > > Committed: https://crrev.com/142f8e1d3e4b75c901f33cb771cd848019630c1e > Cr-Commit-Position: refs/heads/master@{#305069} TBR=lambroslambrou@chromium.org,kelvinp@chromium.org NOTREECHECKS=true NOTRY=true BUG=427512 410050 Committed: https://crrev.com/c72964ad83c6b9ad7cb2a4da4a3bc5e6084fd1f2 Cr-Commit-Position: refs/heads/master@{#305099}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -145 lines) Patch
M remoting/host/it2me/it2me_host.h View 1 chunk +0 lines, -3 lines 0 comments Download
M remoting/host/it2me/it2me_host.cc View 2 chunks +1 line, -8 lines 0 comments Download
M remoting/host/policy_hack/fake_policy_watcher.h View 1 chunk +0 lines, -2 lines 0 comments Download
M remoting/host/policy_hack/fake_policy_watcher.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M remoting/host/policy_hack/mock_policy_callback.h View 1 chunk +0 lines, -3 lines 0 comments Download
M remoting/host/policy_hack/mock_policy_callback.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M remoting/host/policy_hack/policy_watcher.h View 3 chunks +7 lines, -34 lines 0 comments Download
M remoting/host/policy_hack/policy_watcher.cc View 5 chunks +5 lines, -26 lines 0 comments Download
M remoting/host/policy_hack/policy_watcher_linux.cc View 1 chunk +0 lines, -1 line 0 comments Download
M remoting/host/policy_hack/policy_watcher_unittest.cc View 4 chunks +4 lines, -48 lines 0 comments Download
M remoting/host/remoting_me2me_host.cc View 3 chunks +1 line, -12 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
Łukasz Anforowicz
Created Revert of Reporting of policy errors via host-offline-reason: part 1
6 years, 1 month ago (2014-11-20 22:35:31 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/746723002/1
6 years, 1 month ago (2014-11-20 22:36:37 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 1 month ago (2014-11-20 22:36:40 UTC) #4
Łukasz Anforowicz
On 2014/11/20 22:36:40, I haz the power (commit-bot) wrote: > No LGTM from a valid ...
6 years, 1 month ago (2014-11-20 22:47:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/746723002/1
6 years, 1 month ago (2014-11-20 22:48:44 UTC) #9
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 1 month ago (2014-11-20 22:48:47 UTC) #11
Lambros
lgtm
6 years, 1 month ago (2014-11-20 22:51:47 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/746723002/1
6 years, 1 month ago (2014-11-20 22:54:59 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-20 22:57:28 UTC) #15
commit-bot: I haz the power
6 years, 1 month ago (2014-11-20 22:58:43 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c72964ad83c6b9ad7cb2a4da4a3bc5e6084fd1f2
Cr-Commit-Position: refs/heads/master@{#305099}

Powered by Google App Engine
This is Rietveld 408576698