Stub for WebRTCDeviceProvider

chrome/browser/devtools/device/cloud/devtools_bridge_client.h

Index: chrome/browser/devtools/device/cloud/devtools_bridge_client.h
diff --git a/chrome/browser/devtools/device/cloud/devtools_bridge_client.h b/chrome/browser/devtools/device/cloud/devtools_bridge_client.h
new file mode 100644
index 0000000000000000000000000000000000000000..99842307e9e85aa8ee91a22b38f25dc4913c339c
--- /dev/null
+++ b/chrome/browser/devtools/device/cloud/devtools_bridge_client.h
@@ -0,0 +1,40 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_DEVTOOLS_DEVICE_CLOUD_DEVTOOLS_BRIDGE_CLIENT_H_
+#define CHROME_BROWSER_DEVTOOLS_DEVICE_CLOUD_DEVTOOLS_BRIDGE_CLIENT_H_
+
+#include <string>
+
+#include "base/memory/scoped_ptr.h"
+
+namespace content {
+class BrowserContext;
+class WebUIDataSource;
+}
+
+class DevToolsBridgeClient {

[pfeldman, 2014/11/26 11:56:42]

DevToolsBridge name is too generic. What exactly is this class doing?

[SeRya, 2014/11/26 13:09:13]

This class intended to run sessions with remote DevToolsBridgeServer's. It
doesn't have own
signaling channel. Instead it delegates sending commands. It help to:
1. move out some complexity.
2. unit testing: signaling could be mocked.
3. isolation abstraction. It described in terms sessions rather than
DeviceProvider implementation.

+ public:
+  class Delegate {
+   public:
+    virtual void SendCommand(const std::string& command) = 0;
+  };
+
+  virtual ~DevToolsBridgeClient() {}
+
+  static scoped_ptr<DevToolsBridgeClient> CreateInstance(
+      content::BrowserContext* context, Delegate* delegate);
+
+  static void AddResources(content::WebUIDataSource* data_source);
+
+  virtual void StartSession(const std::string& device_id) = 0;

[pfeldman, 2014/11/26 11:56:42]

What is session and where do i get device_id?

[SeRya, 2014/11/26 13:09:13]

It's GCD device ID. It's opaque to the client. Client uses it to create command.

+
+ protected:
+  DevToolsBridgeClient() {}
+
+ private:
+  DISALLOW_COPY_AND_ASSIGN(DevToolsBridgeClient);
+};
+
+#endif  // CHROME_BROWSER_DEVTOOLS_DEVICE_CLOUD_DEVTOOLS_BRIDGE_CLIENT_H_