Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1560)

Issue 746603002: Rebaseline textblobshader expectation for nvpr (Closed)

Created:
6 years, 1 month ago by Chris Dalton
Modified:
6 years, 1 month ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Rebaseline textblobshader expectation for nvpr Rebaseline after https://codereview.chromium.org/712223002. The difference is a result of using different bounding boxes to cover gradient fills, which caused a few pixels do differ by a value of one. BUG=skia: Committed: https://skia.googlesource.com/skia/+/ffe2f1cbd0a8ed8accabb2589afbd16a2b3e39fe

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -14 lines) Patch
M expectations/gm/Test-Android-Nexus9-TegraK1-Arm64-Debug/expected-results.json View 1 chunk +1 line, -1 line 0 comments Download
M expectations/gm/Test-Android-Nexus9-TegraK1-Arm64-Release/expected-results.json View 1 chunk +1 line, -1 line 0 comments Download
M expectations/gm/Test-Ubuntu12-ShuttleA-GTX660-x86-Debug/expected-results.json View 1 chunk +1 line, -1 line 0 comments Download
M expectations/gm/Test-Ubuntu12-ShuttleA-GTX660-x86-Release/expected-results.json View 1 chunk +1 line, -1 line 0 comments Download
M expectations/gm/Test-Ubuntu12-ShuttleA-GTX660-x86_64-Debug/expected-results.json View 1 chunk +1 line, -1 line 0 comments Download
M expectations/gm/Test-Ubuntu12-ShuttleA-GTX660-x86_64-Release/expected-results.json View 1 chunk +1 line, -1 line 0 comments Download
M expectations/gm/Test-Win8-ShuttleA-GTX660-x86-Debug/expected-results.json View 1 chunk +1 line, -1 line 0 comments Download
M expectations/gm/Test-Win8-ShuttleA-GTX660-x86-Release/expected-results.json View 1 chunk +1 line, -1 line 0 comments Download
M expectations/gm/Test-Win8-ShuttleA-GTX660-x86_64-Debug/expected-results.json View 1 chunk +1 line, -1 line 0 comments Download
M expectations/gm/Test-Win8-ShuttleA-GTX660-x86_64-Release/expected-results.json View 1 chunk +1 line, -1 line 0 comments Download
M expectations/gm/ignored-tests.txt View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Chris Dalton
6 years, 1 month ago (2014-11-20 20:28:22 UTC) #2
bsalomon
lgtm
6 years, 1 month ago (2014-11-20 22:21:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/746603002/1
6 years, 1 month ago (2014-11-20 22:21:20 UTC) #5
commit-bot: I haz the power
6 years, 1 month ago (2014-11-20 22:30:13 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/ffe2f1cbd0a8ed8accabb2589afbd16a2b3e39fe

Powered by Google App Engine
This is Rietveld 408576698