Add rsp::GetOffsets command + reply

Add rsp::GetOffsets command + reply

bug=none
test=debugger\rsp\rsp_packets_test.cc
+debugger\rsp\rsp_blob_utils_test.cc
Committed: http://code.google.com/p/nativeclient-sdk/source/detail?r=969

[mmortensen, 2011-07-21 17:19:33]

http://codereview.chromium.org/7466014/diff/1/debugger/rsp/rsp_blob_utils.h
File debugger/rsp/rsp_blob_utils.h (right):

http://codereview.chromium.org/7466014/diff/1/debugger/rsp/rsp_blob_utils.h#n...
debugger/rsp/rsp_blob_utils.h:49: return *blob;
If blob is NULL, we don't want to deference it.
In that case, what reference should we return?

[garianov1, 2011-07-21 17:31:44]

PTAL

http://codereview.chromium.org/7466014/diff/1/debugger/rsp/rsp_blob_utils.h
File debugger/rsp/rsp_blob_utils.h (right):

http://codereview.chromium.org/7466014/diff/1/debugger/rsp/rsp_blob_utils.h#n...
debugger/rsp/rsp_blob_utils.h:49: return *blob;
On 2011/07/21 17:19:33, mmortensen wrote:
> If blob is NULL, we don't want to deference it.
> In that case, what reference should we return?

changed to assert(NULL != blob);

[mmortensen, 2011-07-21 17:36:44]

LGTM
 but please add the comment in rsp_blob_utils.h for sure.
The other file is optional...but would be nice...

http://codereview.chromium.org/7466014/diff/15/debugger/rsp/rsp_blob_utils.h
File debugger/rsp/rsp_blob_utils.h (right):

http://codereview.chromium.org/7466014/diff/15/debugger/rsp/rsp_blob_utils.h#...
debugger/rsp/rsp_blob_utils.h:46: /// leading zeroes are ignored
Please add comments for this funciton with @param format like rest of file

http://codereview.chromium.org/7466014/diff/15/debugger/rsp/rsp_info_packets.cc
File debugger/rsp/rsp_info_packets.cc (right):

http://codereview.chromium.org/7466014/diff/15/debugger/rsp/rsp_info_packets....
debugger/rsp/rsp_info_packets.cc:131: bool GetOffsetsReply::FromBlob(const
std::string& type, debug::Blob* message) {
Optional: these functions don't have comments that describe them...but neither
do the rest in the file.
Would be nice to fix, but it's potentially beyond the scope of the review.

[garianov1, 2011-07-21 17:50:36]

committed as rev 969

http://codereview.chromium.org/7466014/diff/15/debugger/rsp/rsp_blob_utils.h
File debugger/rsp/rsp_blob_utils.h (right):

http://codereview.chromium.org/7466014/diff/15/debugger/rsp/rsp_blob_utils.h#...
debugger/rsp/rsp_blob_utils.h:46: /// leading zeroes are ignored
On 2011/07/21 17:36:44, mmortensen wrote:
> Please add comments for this funciton with @param format like rest of file

Done.

http://codereview.chromium.org/7466014/diff/15/debugger/rsp/rsp_info_packets.cc
File debugger/rsp/rsp_info_packets.cc (right):

http://codereview.chromium.org/7466014/diff/15/debugger/rsp/rsp_info_packets....
debugger/rsp/rsp_info_packets.cc:131: bool GetOffsetsReply::FromBlob(const
std::string& type, debug::Blob* message) {
On 2011/07/21 17:36:44, mmortensen wrote:
> Optional: these functions don't have comments that describe them...but neither
> do the rest in the file.
> Would be nice to fix, but it's potentially beyond the scope of the review.

Will fix in the separate CL.