Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2516)

Unified Diff: chrome/browser/sync/util/user_settings.cc

Issue 7466003: MD5Update function uses StringPiece instead of raw buffer. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Remove line from license. Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/safe_browsing/safe_browsing_store_file.cc ('k') | chrome/common/metrics_helpers.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/sync/util/user_settings.cc
diff --git a/chrome/browser/sync/util/user_settings.cc b/chrome/browser/sync/util/user_settings.cc
index df8ab6b77e0be61f7f74dd9442b4c519655e47c4..6ce150e4b383a417063148f167ed2a48c0325c6f 100644
--- a/chrome/browser/sync/util/user_settings.cc
+++ b/chrome/browser/sync/util/user_settings.cc
@@ -357,8 +357,8 @@ void UserSettings::StoreHashedPassword(const string& email,
const string salt = APEncode(string(binary_salt, sizeof(binary_salt)));
base::MD5Context md5_context;
base::MD5Init(&md5_context);
- base::MD5Update(&md5_context, salt.data(), salt.size());
- base::MD5Update(&md5_context, password.data(), password.size());
+ base::MD5Update(&md5_context, salt);
+ base::MD5Update(&md5_context, password);
base::MD5Digest md5_digest;
base::MD5Final(&md5_digest, &md5_context);
@@ -420,8 +420,8 @@ bool UserSettings::VerifyAgainstStoredHash(const string& email,
return false;
base::MD5Context md5_context;
base::MD5Init(&md5_context);
- base::MD5Update(&md5_context, salt.data(), salt.size());
- base::MD5Update(&md5_context, password.data(), password.size());
+ base::MD5Update(&md5_context, salt);
+ base::MD5Update(&md5_context, password);
base::MD5Digest md5_digest;
base::MD5Final(&md5_digest, &md5_context);
return hash == GetHashFromDigest(md5_digest);
« no previous file with comments | « chrome/browser/safe_browsing/safe_browsing_store_file.cc ('k') | chrome/common/metrics_helpers.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698