Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Issue 746563002: Revert of Add chrome sync tests to the GN build. (Closed)

Created:
6 years, 1 month ago by Pete Williamson
Modified:
6 years, 1 month ago
Reviewers:
brettw, scottmg
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Add chrome sync tests to the GN build. (patchset #3 id:40001 of https://codereview.chromium.org/717923006/) Reason for revert: This seems the most likely culprit behind sync_integration_test build and test errors that started in the patch that included this change. Original issue's description: > Add chrome sync tests to the GN build. > > This adds sync_integration_tests, sync_performance_tests, and the sync test support targets. > > I removed some files that were duplicated between the sync integration tests and the test support. In GYP the fact that test support was a static library hid the duplicate symbols. > > Add a dependency on sessions_core from sessions test support since it's required to link. Made test support target be a source set (linking source sets into static libraries will often duplicate symbols). > > Committed: https://crrev.com/d60468061789084ebd98458b9743726cc1541786 > Cr-Commit-Position: refs/heads/master@{#304904} TBR=scottmg@chromium.org,brettw@chromium.org NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/9d02b68215deb718ed531998323ebedd71d090bf Cr-Commit-Position: refs/heads/master@{#305058}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -183 lines) Patch
M chrome/chrome_tests.gypi View 7 chunks +9 lines, -6 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/test/BUILD.gn View 2 chunks +0 lines, -173 lines 0 comments Download
M components/sessions/BUILD.gn View 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Pete Williamson
Created Revert of Add chrome sync tests to the GN build.
6 years, 1 month ago (2014-11-20 19:13:23 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/746563002/1
6 years, 1 month ago (2014-11-20 19:13:57 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-20 19:15:00 UTC) #3
commit-bot: I haz the power
6 years, 1 month ago (2014-11-20 19:15:48 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9d02b68215deb718ed531998323ebedd71d090bf
Cr-Commit-Position: refs/heads/master@{#305058}

Powered by Google App Engine
This is Rietveld 408576698