Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(417)

Issue 7465053: In chromedriver, check if an element is clickable before clicking. (Closed)

Created:
9 years, 5 months ago by kkania
Modified:
9 years, 4 months ago
CC:
chromium-reviews, kkania, Paweł Hajdan Jr.
Visibility:
Public.

Description

In chromedriver, check if an element is clickable before clicking. Using new atom from http://code.google.com/p/selenium/source/detail?spec=svn13098&r=13091. Update webdriver atoms/bindings to 13091. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=94584

Patch Set 1 #

Total comments: 2

Patch Set 2 : ... #

Patch Set 3 : ... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1485 lines, -1369 lines) Patch
M DEPS View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/webdriver/session.h View 1 2 chunks +10 lines, -1 line 0 comments Download
M chrome/test/webdriver/session.cc View 1 2 6 chunks +66 lines, -5 lines 0 comments Download
M chrome/test/webdriver/test/chromedriver_tests.py View 3 chunks +8 lines, -3 lines 0 comments Download
A chrome/test/webdriver/test/not_clickable.html View 1 chunk +15 lines, -0 lines 0 comments Download
M third_party/webdriver/README.chromium View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/webdriver/atoms.h View 19 chunks +1382 lines, -1356 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
kkania
9 years, 5 months ago (2011-07-26 21:49:15 UTC) #1
Huyen
LGTM http://codereview.chromium.org/7465053/diff/1/chrome/test/webdriver/session.h File chrome/test/webdriver/session.h (right): http://codereview.chromium.org/7465053/diff/1/chrome/test/webdriver/session.h#newcode320 chrome/test/webdriver/session.h:320: Error* VerifyElementIsClickable( Maybe add comments stating an error ...
9 years, 5 months ago (2011-07-27 22:23:23 UTC) #2
kkania
http://codereview.chromium.org/7465053/diff/1/chrome/test/webdriver/session.h File chrome/test/webdriver/session.h (right): http://codereview.chromium.org/7465053/diff/1/chrome/test/webdriver/session.h#newcode320 chrome/test/webdriver/session.h:320: Error* VerifyElementIsClickable( On 2011/07/27 22:23:23, Huyen wrote: > Maybe ...
9 years, 4 months ago (2011-07-28 16:44:08 UTC) #3
commit-bot: I haz the power
9 years, 4 months ago (2011-07-28 23:31:22 UTC) #4
Change committed as 94584

Powered by Google App Engine
This is Rietveld 408576698