Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 746483002: Instrumenting the code to check if jank was caused by first access to mmapped pointer. (Closed)

Created:
6 years, 1 month ago by vadimt
Modified:
6 years, 1 month ago
Reviewers:
mmenke
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Instrumenting the code to check if jank was caused by first access to mmapped pointer. After the fix, jankiness disappeared from the task tracked by this bug. Before the fix, jankiness of URLRequestSimpleJob::StartAsync was 18.1jph. However, jankiness of URLRequest::Delegate::OnResponseStarted went up from 23.7 to 42 jph. That task is tracked by another bug 423948. This could mean the page fault exception that moved to another place. I'm instrumenting the suspicious place mentioned in earlier conversations. BUG=422489 Committed: https://crrev.com/522a6a68af27cc55510c9d27b3407ff49143b9e3 Cr-Commit-Position: refs/heads/master@{#305046}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M net/url_request/url_request_simple_job.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
vadimt
mmenke@, please provide OWNER's approval
6 years, 1 month ago (2014-11-20 16:41:29 UTC) #2
mmenke
On 2014/11/20 16:41:29, vadimt wrote: > mmenke@, please provide OWNER's approval You'll need to update ...
6 years, 1 month ago (2014-11-20 16:44:21 UTC) #3
vadimt
Yes, I removed this file from the other CL.
6 years, 1 month ago (2014-11-20 16:48:58 UTC) #4
mmenke
On 2014/11/20 16:48:58, vadimt wrote: > Yes, I removed this file from the other CL. ...
6 years, 1 month ago (2014-11-20 16:49:31 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/746483002/1
6 years, 1 month ago (2014-11-20 16:51:37 UTC) #7
mmenke
On 2014/11/20 16:51:37, I haz the power (commit-bot) wrote: > CQ is trying da patch. ...
6 years, 1 month ago (2014-11-20 16:57:07 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-20 18:41:33 UTC) #9
commit-bot: I haz the power
6 years, 1 month ago (2014-11-20 18:42:33 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/522a6a68af27cc55510c9d27b3407ff49143b9e3
Cr-Commit-Position: refs/heads/master@{#305046}

Powered by Google App Engine
This is Rietveld 408576698