Issue 746473003: Teach skydb about --release and --debug

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 746473003: Teach skydb about --release and --debug (Closed)

Created:
6 years, 1 month ago by abarth-chromium

Modified:
6 years, 1 month ago

Reviewers:
eseidel

CC:
mojo-reviews_chromium.org, ojan, esprehn

Base URL:
git@github.com:domokit/mojo.git@master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Teach skydb about --release and --debug Previously, skydb could be used only for Debug builds. As part of working on graphics performance, I'd like to use it for release builds as well. This CL teaches it to use the same configuration arguments as sky_server, test_sky, and test_perf. The downside of this CL is that you'll need to supply --debug in the common case of working with a debug build. R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/5d6be094aa671fb4073da995dc9c03cc8ac494c1

Patch Set 1 #

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -4 lines)			Patch
	M	sky/tools/skydb	View		5 chunks	+8 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

abarth-chromium

6 years, 1 month ago (2014-11-20 22:40:15 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
5d6be094aa671fb4073da995dc9c03cc8ac494c1 (presubmit successful).

Expand Messages | Collapse Messages