Issue 746453002: Don't send duplicate responses for debugger commands in Sky

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 746453002: Don't send duplicate responses for debugger commands in Sky (Closed)

Created:
6 years, 1 month ago by yurys

Modified:
6 years, 1 month ago

Reviewers:
abarth-chromium, eseidel

CC:
abarth-chromium, esprehn, mojo-reviews_chromium.org, ojan

Base URL:
https://github.com/domokit/mojo.git@master

Project:
mojo

Visibility:
Public.

Don't send duplicate responses for debugger commands in Sky This fixes following error in DevTools front-end: "Protocol Error: the message with wrong id. " and makes breakpoint persist between debugging sessions. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/5c23174c2cbf22ef8fcf44df819da0a4fced803b

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -1 line)			Patch
	M	sky/framework/inspector/inspector.sky	View		3 chunks	+4 lines, -1 line	0 comments	Download

Total messages: 4 (1 generated)

yurys

6 years, 1 month ago (2014-11-20 17:17:29 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
5c23174c2cbf22ef8fcf44df819da0a4fced803b (presubmit successful).