Win/Clang: the ASan run-time DLL has moved

Win/Clang: the ASan run-time DLL has moved

BUG=345874
NOTRY=true

Committed: https://crrev.com/c5a784437a72c5a881751bac2aa682eaf9d89784
Cr-Commit-Position: refs/heads/master@{#306888}

[hans, 2014-12-04 19:12:19]

hans@chromium.org changed reviewers:
+ thakis@chromium.org, timurrrr@chromium.org

[hans, 2014-12-04 19:12:20]

I'm about to move the run-time DLL into the lib/ dir with
http://reviews.llvm.org/D6508


The problem is that the ASan lkgr bot, clusterfuzz and devs trying out asan=1
locally will not pick up that revision because LLVM_WIN_REVISION is pinned for
those cases :/

[hans, 2014-12-04 20:29:45]

Uploaded a new version that I think will make the pinned version work too.

It's kind of fiddly to test this, so if you think it looks reasonable, I'd like
to land it and have the bots test it for me.

[Nico, 2014-12-04 20:31:56]

https://codereview.chromium.org/746423005/diff/20001/tools/clang/scripts/upda...
File tools/clang/scripts/update.py (right):

https://codereview.chromium.org/746423005/diff/20001/tools/clang/scripts/upda...
tools/clang/scripts/update.py:231: r'^.*-i386\.dll$')
Won't this copy the old dll that's around from a previous build? Shouldn't the
logic be "if file doesn't exist in new place, copy it there?

[hans, 2014-12-04 20:33:06]

https://codereview.chromium.org/746423005/diff/20001/tools/clang/scripts/upda...
File tools/clang/scripts/update.py (right):

https://codereview.chromium.org/746423005/diff/20001/tools/clang/scripts/upda...
tools/clang/scripts/update.py:231: r'^.*-i386\.dll$')
On 2014/12/04 20:31:56, Nico wrote:
> Won't this copy the old dll that's around from a previous build? Shouldn't the
> logic be "if file doesn't exist in new place, copy it there?

The copy below will overwrite any old file with a new one if it exists. I think
that's safe enough?

[Nico, 2014-12-04 20:35:53]

oh, i see. lgtm!

(timur, abishek: things like this are why i'm not a fan of asan using its own
special pinned version, that by now is probably a month behind head :-/)

[hans, 2014-12-04 20:56:45]

The CQ bit was checked by hans@chromium.org

[hans, 2014-12-04 20:57:00]

The CQ bit was unchecked by hans@chromium.org

[hans, 2014-12-04 20:57:07]

The CQ bit was checked by hans@chromium.org

[commit-bot: I haz the power, 2014-12-04 20:57:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/746423005/20001

[commit-bot: I haz the power, 2014-12-04 21:01:11]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2014-12-04 21:02:04]

Patchset 2 (id:??) landed as
https://crrev.com/c5a784437a72c5a881751bac2aa682eaf9d89784
Cr-Commit-Position: refs/heads/master@{#306888}

[Timur Iskhodzhanov, 2014-12-05 11:20:39]

Thanks for taking care of the pinned revision too!