Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 746403004: gn: some vim support files (Closed)

Created:
6 years ago by scottmg
Modified:
6 years ago
Reviewers:
Dirk Pranke, brettw, jamesr
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

gn: some vim support files - Syntax highlighting, keywords, etc. based on gn help. - Set filetype (to make them always \n, not \r\n, and always utf-8) R=dpranke@chromium.org,brettw@chromium.org Committed: https://crrev.com/896e7cecbaf8e8ee16e8ec659ed50a758bae6974 Cr-Commit-Position: refs/heads/master@{#305560}

Patch Set 1 #

Patch Set 2 : fiddle #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+112 lines, -0 lines) Patch
A tools/gn/misc/vim/README.chromium View 1 chunk +5 lines, -0 lines 3 comments Download
A tools/gn/misc/vim/ftdetect/gnfiletype.vim View 1 chunk +27 lines, -0 lines 0 comments Download
A tools/gn/misc/vim/syntax/gn.vim View 1 1 chunk +80 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
scottmg
(Do either of you use Vim? Otherwise, I can get someone else to stamp.)
6 years ago (2014-11-24 23:46:43 UTC) #6
jamesr
I have no idea what vimscript syntax is, but this looks nice. lgtm
6 years ago (2014-11-25 01:12:00 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/746403004/100001
6 years ago (2014-11-25 01:13:30 UTC) #10
tfarina
Nice! https://codereview.chromium.org/746403004/diff/100001/tools/gn/misc/vim/README.chromium File tools/gn/misc/vim/README.chromium (right): https://codereview.chromium.org/746403004/diff/100001/tools/gn/misc/vim/README.chromium#newcode3 tools/gn/misc/vim/README.chromium:3: set runtimepath^=.../tools/gn/misc/vim += ? https://codereview.chromium.org/746403004/diff/100001/tools/gn/misc/vim/README.chromium#newcode3 tools/gn/misc/vim/README.chromium:3: set runtimepath^=.../tools/gn/misc/vim ...
6 years ago (2014-11-25 01:52:42 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:100001)
6 years ago (2014-11-25 01:54:02 UTC) #12
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/896e7cecbaf8e8ee16e8ec659ed50a758bae6974 Cr-Commit-Position: refs/heads/master@{#305560}
6 years ago (2014-11-25 01:54:48 UTC) #13
scottmg
6 years ago (2014-11-25 03:25:36 UTC) #14
Message was sent while issue was closed.
https://codereview.chromium.org/746403004/diff/100001/tools/gn/misc/vim/READM...
File tools/gn/misc/vim/README.chromium (right):

https://codereview.chromium.org/746403004/diff/100001/tools/gn/misc/vim/READM...
tools/gn/misc/vim/README.chromium:3: set runtimepath^=.../tools/gn/misc/vim
On 2014/11/25 01:52:42, tfarina wrote:
> += ?

^= is prepend, += is append. Either will work fine.

Powered by Google App Engine
This is Rietveld 408576698