Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(554)

Unified Diff: sky/tools/webkitpy/layout_tests/port/base.py

Issue 746373002: Convert sky_server over to a go-based http server. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: address review comments Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/tools/test_perf ('k') | sky/tools/webkitpy/layout_tests/run_webkit_tests.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/tools/webkitpy/layout_tests/port/base.py
diff --git a/sky/tools/webkitpy/layout_tests/port/base.py b/sky/tools/webkitpy/layout_tests/port/base.py
index 62681f66909ad75ac90506ffdc15e8e66c709f4a..18f0303050faa011936d277ae64b9e06ecde411a 100644
--- a/sky/tools/webkitpy/layout_tests/port/base.py
+++ b/sky/tools/webkitpy/layout_tests/port/base.py
@@ -1092,8 +1092,10 @@ class Port(object):
return True
def server_command_line(self):
+ path = (self._options.path_to_server or
+ self.path_from_chromium_base('out', 'downloads', 'sky_server'))
return [
- self.path_to_script('sky_server'),
+ path,
'-t', self.get_option('configuration'),
self.path_from_chromium_base(),
'8000',
@@ -1104,6 +1106,7 @@ class Port(object):
Ports can stub this out if they don't need a web server to be running."""
assert not self._http_server, 'Already running an http server.'
+ subprocess.call(self.path_to_script('download_sky_server'))
self._http_server = subprocess.Popen(self.server_command_line())
def start_websocket_server(self):
« no previous file with comments | « sky/tools/test_perf ('k') | sky/tools/webkitpy/layout_tests/run_webkit_tests.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698