Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(325)

Issue 746363003: Add fetch recipe for the Skia repository. (Closed)

Created:
6 years, 1 month ago by tfarina
Modified:
6 years ago
Reviewers:
agable
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, iannucci+depot_tools_chromium.org, borenet, rmistry, ghost stip (do not use)
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Project:
tools
Visibility:
Public.

Description

Add fetch recipe for the Skia repository. Tested with the following command lines: $ cd somewhere $ mkdir some-test-dir $ cd some-test-dir $ fetch skia $ cd skia # confirm it is what we expected. BUG=None TEST=see above R=agable@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=293135

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -15 lines) Patch
A + recipes/skia.py View 2 chunks +9 lines, -15 lines 0 comments Download

Messages

Total messages: 19 (7 generated)
tfarina
Hi Robert, could you review this to me? Thanks,
6 years, 1 month ago (2014-11-22 22:25:59 UTC) #1
agable
On 2014/11/22 22:25:59, tfarina wrote: > Hi Robert, could you review this to me? > ...
6 years ago (2014-11-24 21:13:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/746363003/1
6 years ago (2014-11-24 23:27:09 UTC) #4
commit-bot: I haz the power
Presubmit check for 746363003-1 failed and returned exit status 1. Running presubmit commit checks ...
6 years ago (2014-11-24 23:28:51 UTC) #6
tfarina
On 2014/11/24 23:28:51, I haz the power (commit-bot) wrote: > Presubmit check for 746363003-1 failed ...
6 years ago (2014-11-25 01:59:15 UTC) #7
tfarina
On 2014/11/24 23:28:51, I haz the power (commit-bot) wrote: > Presubmit check for 746363003-1 failed ...
6 years ago (2014-11-25 02:00:43 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/746363003/1
6 years ago (2014-11-25 13:01:50 UTC) #10
commit-bot: I haz the power
Presubmit check for 746363003-1 failed and returned exit status 1. Running presubmit commit checks ...
6 years ago (2014-11-25 13:03:33 UTC) #12
tfarina
Aaron, ping?
6 years ago (2014-11-26 02:04:41 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/746363003/1
6 years ago (2014-11-26 02:05:27 UTC) #16
commit-bot: I haz the power
Presubmit check for 746363003-1 failed and returned exit status 1. Running presubmit commit checks ...
6 years ago (2014-11-26 02:07:35 UTC) #18
tfarina
6 years ago (2014-11-27 13:26:56 UTC) #19
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 293135.

Powered by Google App Engine
This is Rietveld 408576698