|
|
Created:
6 years, 1 month ago by tfarina Modified:
6 years ago Reviewers:
agable CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, iannucci+depot_tools_chromium.org, borenet, rmistry, ghost stip (do not use) Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master Project:
tools Visibility:
Public. |
DescriptionAdd fetch recipe for the Skia repository.
Tested with the following command lines:
$ cd somewhere
$ mkdir some-test-dir
$ cd some-test-dir
$ fetch skia
$ cd skia
# confirm it is what we expected.
BUG=None
TEST=see above
R=agable@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=293135
Patch Set 1 #
Messages
Total messages: 19 (7 generated)
Hi Robert, could you review this to me? Thanks,
On 2014/11/22 22:25:59, tfarina wrote: > Hi Robert, could you review this to me? > > Thanks, LGTM!
The CQ bit was checked by tfarina@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/746363003/1
The CQ bit was unchecked by commit-bot@chromium.org
Presubmit check for 746363003-1 failed and returned exit status 1. Running presubmit commit checks ... Checking out rietveld... Running save-description-on-failure.sh Running push-basic.sh Running upstream.sh Running submit-from-new-dir.sh Running abandon.sh Running submodule-merge-test.sh Running upload-local-tracking-branch.sh Running hooks.sh Running post-dcommit-hook-test.sh Running upload-stale.sh Running patch.sh Running basic.sh ** Presubmit ERRORS ** Pylint (110 files) (61.62s) failed /b/depot_tools/third_party/logilab/astroid/modutils.py:520: UserWarning: Module six was already imported from /b/depot_tools/third_party/six/__init__.py, but /usr/local/lib/python2.7/dist-packages is being added to sys.path import pkg_resources Problem importing module .svn: No module named .svn Problem importing module .svn: No module named .svn ************* Module fix_encoding E:232, 0: Slice index is not an int, None, or instance with __index__ (invalid-slice-index) ************* Module gclient_scm E:301,18: No value for argument 'print_func' in constructor call (no-value-for-parameter) E:1191,18: No value for argument 'print_func' in constructor call (no-value-for-parameter) Presubmit checks took 99.2s to calculate.
On 2014/11/24 23:28:51, I haz the power (commit-bot) wrote: > Presubmit check for 746363003-1 failed and returned exit status 1. > > Running presubmit commit checks ... > Checking out rietveld... > Running save-description-on-failure.sh > Running push-basic.sh > Running upstream.sh > Running submit-from-new-dir.sh > Running abandon.sh > Running submodule-merge-test.sh > Running upload-local-tracking-branch.sh > Running hooks.sh > Running post-dcommit-hook-test.sh > Running upload-stale.sh > Running patch.sh > Running basic.sh > > ** Presubmit ERRORS ** > Pylint (110 files) (61.62s) failed > /b/depot_tools/third_party/logilab/astroid/modutils.py:520: UserWarning: Module > six was already imported from /b/depot_tools/third_party/six/__init__.py, but > /usr/local/lib/python2.7/dist-packages is being added to sys.path > import pkg_resources > Problem importing module .svn: No module named .svn > Problem importing module .svn: No module named .svn > ************* Module fix_encoding > E:232, 0: Slice index is not an int, None, or instance with __index__ > (invalid-slice-index) > ************* Module gclient_scm > E:301,18: No value for argument 'print_func' in constructor call > (no-value-for-parameter) > E:1191,18: No value for argument 'print_func' in constructor call > (no-value-for-parameter) > > > Presubmit checks took 99.2s to calculate.
On 2014/11/24 23:28:51, I haz the power (commit-bot) wrote: > Presubmit check for 746363003-1 failed and returned exit status 1. > > Running presubmit commit checks ... > Checking out rietveld... > Running save-description-on-failure.sh > Running push-basic.sh > Running upstream.sh > Running submit-from-new-dir.sh > Running abandon.sh > Running submodule-merge-test.sh > Running upload-local-tracking-branch.sh > Running hooks.sh > Running post-dcommit-hook-test.sh > Running upload-stale.sh > Running patch.sh > Running basic.sh > > ** Presubmit ERRORS ** > Pylint (110 files) (61.62s) failed > /b/depot_tools/third_party/logilab/astroid/modutils.py:520: UserWarning: Module > six was already imported from /b/depot_tools/third_party/six/__init__.py, but > /usr/local/lib/python2.7/dist-packages is being added to sys.path > import pkg_resources > Problem importing module .svn: No module named .svn > Problem importing module .svn: No module named .svn > ************* Module fix_encoding > E:232, 0: Slice index is not an int, None, or instance with __index__ > (invalid-slice-index) > ************* Module gclient_scm > E:301,18: No value for argument 'print_func' in constructor call > (no-value-for-parameter) > E:1191,18: No value for argument 'print_func' in constructor call > (no-value-for-parameter) > > How do I fix these errors? How can I bypass this? I can't land manually with `git cl land --bypass-hooks`: fatal: remote error: Git access forbidden Failed to push. If this persists, please file a bug. Is there a way to commit this with CQ bypassing those errors?
The CQ bit was checked by tfarina@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/746363003/1
The CQ bit was unchecked by commit-bot@chromium.org
Presubmit check for 746363003-1 failed and returned exit status 1. Running presubmit commit checks ... Checking out rietveld... Running save-description-on-failure.sh Running push-basic.sh Running upstream.sh Running submit-from-new-dir.sh Running abandon.sh Running submodule-merge-test.sh Running upload-local-tracking-branch.sh Running hooks.sh Running post-dcommit-hook-test.sh Running upload-stale.sh Running patch.sh Running basic.sh ** Presubmit ERRORS ** Pylint (110 files) (60.34s) failed /b/depot_tools/third_party/logilab/astroid/modutils.py:520: UserWarning: Module six was already imported from /b/depot_tools/third_party/six/__init__.py, but /usr/local/lib/python2.7/dist-packages is being added to sys.path import pkg_resources Problem importing module .svn: No module named .svn Problem importing module .svn: No module named .svn ************* Module fix_encoding E:232, 0: Slice index is not an int, None, or instance with __index__ (invalid-slice-index) ************* Module gclient_scm E:301,18: No value for argument 'print_func' in constructor call (no-value-for-parameter) E:1191,18: No value for argument 'print_func' in constructor call (no-value-for-parameter) Presubmit checks took 98.8s to calculate. Was the presubmit check useful? If not, run "git cl presubmit -v" to figure out which PRESUBMIT.py was run, then run git blame on the file to figure out who to ask for help.
tfarina@chromium.org changed reviewers: + agable@chromium.org - iannucci@chromium.org
Aaron, ping?
The CQ bit was checked by tfarina@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/746363003/1
The CQ bit was unchecked by commit-bot@chromium.org
Presubmit check for 746363003-1 failed and returned exit status 1. Running presubmit commit checks ... Checking out rietveld... Running save-description-on-failure.sh Running push-basic.sh Running upstream.sh Running submit-from-new-dir.sh Running abandon.sh Running submodule-merge-test.sh Running upload-local-tracking-branch.sh Running hooks.sh Running post-dcommit-hook-test.sh Running upload-stale.sh Running patch.sh Running basic.sh ** Presubmit ERRORS ** Pylint (110 files) (63.85s) failed /b/depot_tools/third_party/logilab/astroid/modutils.py:520: UserWarning: Module six was already imported from /b/depot_tools/third_party/six/__init__.py, but /usr/local/lib/python2.7/dist-packages is being added to sys.path import pkg_resources Problem importing module .svn: No module named .svn Problem importing module .svn: No module named .svn ************* Module fix_encoding E:232, 0: Slice index is not an int, None, or instance with __index__ (invalid-slice-index) ************* Module gclient_scm E:301,18: No value for argument 'print_func' in constructor call (no-value-for-parameter) E:1191,18: No value for argument 'print_func' in constructor call (no-value-for-parameter) Presubmit checks took 121.4s to calculate.
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 293135. |