Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(625)

Issue 746343004: Send the remote tracked ref to Rietveld via upload.py (Closed)

Created:
6 years ago by rmistry
Modified:
6 years ago
CC:
chromium-reviews, rmistry+cc_chromium.org
Base URL:
https://chromium.googlesource.com/infra/infra@master
Project:
infra
Visibility:
Public.

Description

Send the remote tracked ref to Rietveld via upload.py This change is due to https://codereview.chromium.org/781523002/ More context is in Aaron's comment here: https://codereview.chromium.org/781523002/#msg11 BUG=435702 TBR= NOTRY=true Committed: https://chromium.googlesource.com/infra/infra/+/83e54e5867629315b1af364ea39315664f0630b2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M appengine/chromium_rietveld/upload.py View 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
rmistry
6 years ago (2014-12-09 23:56:36 UTC) #2
Jason Robbins -- corp
lgtm
6 years ago (2014-12-10 00:01:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/746343004/1
6 years ago (2014-12-10 12:26:02 UTC) #6
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years ago (2014-12-10 12:26:05 UTC) #8
rmistry
On 2014/12/10 12:26:05, I haz the power (commit-bot) wrote: > No LGTM from a valid ...
6 years ago (2014-12-10 12:28:17 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/746343004/1
6 years ago (2014-12-10 12:29:02 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/746343004/1
6 years ago (2014-12-10 12:34:32 UTC) #14
commit-bot: I haz the power
6 years ago (2014-12-10 12:34:46 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/infra/infra/+/83e54e5867629315b1af364ea3931...

Powered by Google App Engine
This is Rietveld 408576698