Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Side by Side Diff: PRESUBMIT.py

Issue 746303002: Make gn check //examples/* pass (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | examples/apptest/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """Top-level presubmit script for Chromium. 5 """Top-level presubmit script for Chromium.
6 6
7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
8 for more details about the presubmit API built into gcl. 8 for more details about the presubmit API built into gcl.
9 """ 9 """
10 10
(...skipping 426 matching lines...) Expand 10 before | Expand all | Expand 10 after
437 relative_out_dir = input_api.os_path.relpath(out_dir, temp_parent) 437 relative_out_dir = input_api.os_path.relpath(out_dir, temp_parent)
438 try: 438 try:
439 input_api.subprocess.check_output(['gn', 'gen', relative_out_dir]) 439 input_api.subprocess.check_output(['gn', 'gen', relative_out_dir])
440 except input_api.subprocess.CalledProcessError, error: 440 except input_api.subprocess.CalledProcessError, error:
441 return [output_api.PresubmitError( 441 return [output_api.PresubmitError(
442 'gn gen must not fail.', long_text=error.output)] 442 'gn gen must not fail.', long_text=error.output)]
443 443
444 # TODO(eseidel): Currently only these are known to pass, 444 # TODO(eseidel): Currently only these are known to pass,
445 # once everything passes we can just call 'gn check' once without a filter! 445 # once everything passes we can just call 'gn check' once without a filter!
446 KNOWN_PASSING = [ 446 KNOWN_PASSING = [
447 '//examples/*',
447 '//mojo/aura/*', 448 '//mojo/aura/*',
448 '//mojo/application/*', 449 '//mojo/application/*',
449 '//mojo/application_manager/*', 450 '//mojo/application_manager/*',
450 '//mojo/cc/*', 451 '//mojo/cc/*',
451 '//mojo/common/*', 452 '//mojo/common/*',
452 '//mojo/converters/*', 453 '//mojo/converters/*',
453 '//mojo/edk/*', 454 '//mojo/edk/*',
454 '//mojo/environment/*', 455 '//mojo/environment/*',
455 '//mojo/gles2/*', 456 '//mojo/gles2/*',
456 '//mojo/gpu/*', 457 '//mojo/gpu/*',
(...skipping 1158 matching lines...) Expand 10 before | Expand all | Expand 10 after
1615 files = change.LocalPaths() 1616 files = change.LocalPaths()
1616 1617
1617 if not files or all(re.search(r'[\\\/]OWNERS$', f) for f in files): 1618 if not files or all(re.search(r'[\\\/]OWNERS$', f) for f in files):
1618 return {} 1619 return {}
1619 1620
1620 builders = [ 1621 builders = [
1621 'Mojo Linux Try', 1622 'Mojo Linux Try',
1622 ] 1623 ]
1623 1624
1624 return GetDefaultTryConfigs(builders) 1625 return GetDefaultTryConfigs(builders)
OLDNEW
« no previous file with comments | « no previous file | examples/apptest/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698