Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 746263002: Ensure external snapshot is only set once. (Closed)

Created:
6 years, 1 month ago by baixo
Modified:
6 years ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Project:
v8
Visibility:
Public.

Description

Ensure external snapshot is only set once. BUG=421063

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -10 lines) Patch
M src/api.cc View 1 chunk +2 lines, -10 lines 0 comments Download
M src/v8.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/v8.cc View 3 chunks +24 lines, -0 lines 2 comments Download

Messages

Total messages: 8 (2 generated)
baixo1
Could you please take a look? Thanks!
6 years, 1 month ago (2014-11-21 18:51:08 UTC) #2
rmcilroy
On 2014/11/21 18:51:08, baixo1 wrote: > Could you please take a look? > > Thanks! ...
6 years, 1 month ago (2014-11-21 18:53:29 UTC) #3
rmcilroy
On 2014/11/21 18:51:08, baixo1 wrote: > Could you please take a look? > > Thanks! ...
6 years, 1 month ago (2014-11-21 18:53:31 UTC) #4
rmcilroy
this time with the comments... https://codereview.chromium.org/746263002/diff/1/src/v8.cc File src/v8.cc (right): https://codereview.chromium.org/746263002/diff/1/src/v8.cc#newcode127 src/v8.cc:127: nit - remove extra ...
6 years, 1 month ago (2014-11-21 18:53:46 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/746263002/1
6 years ago (2014-11-24 12:16:13 UTC) #7
commit-bot: I haz the power
6 years ago (2014-11-24 12:44:39 UTC) #8
Message was sent while issue was closed. 
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698