Issue 746253003: Add IndexType parameter to GrDrawTarget::drawPaths

Issue 746253003: Add IndexType parameter to GrDrawTarget::drawPaths (Closed)

Created:
6 years, 1 month ago by Chris Dalton

Modified:
6 years ago

Reviewers:
bsalomon

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

Add IndexType parameter to GrDrawTarget::drawPaths Allows the caller to decide whether they sent 8, 16, or 32 bit path indices. BUG=skia: Committed: https://skia.googlesource.com/skia/+/55b24afc178e641e17a5664beba7ab2b4982c91a

Created: 6 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+152 lines, -88 lines)			Patch
M	src/gpu/GrDrawTarget.h	View	1	3 chunks	+19 lines, -15 lines	0 comments	Download
M	src/gpu/GrDrawTarget.cpp	View	1	2 chunks	+8 lines, -6 lines	0 comments	Download
M	src/gpu/GrGpu.h	View	1	1 chunk	+4 lines, -3 lines	0 comments	Download
M	src/gpu/GrGpu.cpp	View	1	2 chunks	+7 lines, -6 lines	0 comments	Download
M	src/gpu/GrInOrderDrawBuffer.h	View	1	4 chunks	+10 lines, -8 lines	0 comments	Download
M	src/gpu/GrInOrderDrawBuffer.cpp	View	1	4 chunks	+24 lines, -13 lines	0 comments	Download
M	src/gpu/GrPathRange.h	View	1	2 chunks	+20 lines, -2 lines	0 comments	Download
M	src/gpu/GrPathRange.cpp	View	1	1 chunk	+16 lines, -4 lines	0 comments	Download
M	src/gpu/GrPathRendering.h	View	1	3 chunks	+15 lines, -13 lines	0 comments	Download
M	src/gpu/GrStencilAndCoverTextContext.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/gpu/GrStencilAndCoverTextContext.cpp	View	1 2	1 chunk	+3 lines, -3 lines	0 comments	Download
M	src/gpu/gl/GrGLPathRendering.h	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/gpu/gl/GrGLPathRendering.cpp	View	1	3 chunks	+23 lines, -12 lines	0 comments	Download

Total messages: 8 (2 generated)

Chris Dalton

This saves a bit of memory bandwidth, but the main advantage is it will let ...

6 years ago (2014-11-25 06:26:59 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/746253003/40001

6 years ago (2014-11-25 18:51:30 UTC) #7

commit-bot: I haz the power

6 years ago (2014-11-25 19:01:01 UTC) #8

Message was sent while issue was closed.

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/55b24afc178e641e17a5664beba7ab2b4982c91a