Create GrOptDrawState directly in the cmd buffer in GrIODB.

Create GrOptDrawState directly in the cmd buffer in GrIODB.

Committed: https://skia.googlesource.com/skia/+/932f8669875f5d63b8c04571931e6f4224e66e0b

[bsalomon, 2014-11-21 18:47:49]

bsalomon@google.com changed reviewers:
+ egdaniel@google.com, joshualitt@google.com

[egdaniel, 2014-11-21 22:26:24]

lgtm with minor name comment, but VERY IMPORTANT style nits

https://codereview.chromium.org/746243002/diff/40001/src/gpu/GrInOrderDrawBuf...
File src/gpu/GrInOrderDrawBuffer.cpp (right):

https://codereview.chromium.org/746243002/diff/40001/src/gpu/GrInOrderDrawBuf...
src/gpu/GrInOrderDrawBuffer.cpp:530: void
GrInOrderDrawBuffer::SetState::execute(GrInOrderDrawBuffer*, const
GrOptDrawState*) { }
extra space in { }

https://codereview.chromium.org/746243002/diff/40001/src/gpu/GrInOrderDrawBuf...
File src/gpu/GrInOrderDrawBuffer.h (right):

https://codereview.chromium.org/746243002/diff/40001/src/gpu/GrInOrderDrawBuf...
src/gpu/GrInOrderDrawBuffer.h:220: , fState(drawState, gpu, scissor, dstCopy,
drawType) { }
no space :)

https://codereview.chromium.org/746243002/diff/40001/src/gpu/GrInOrderDrawBuf...
src/gpu/GrInOrderDrawBuffer.h:316: const GrOptDrawState*              
fLastState;
personally I like the name fPreviousState or even fCurrentState (if you tilt
your head sideways you can kind of see it as current) better than fLastState.
But I really don't have any negative thoughts on last so your call.

[bsalomon, 2014-11-24 14:36:57]

https://codereview.chromium.org/746243002/diff/40001/src/gpu/GrInOrderDrawBuf...
File src/gpu/GrInOrderDrawBuffer.cpp (right):

https://codereview.chromium.org/746243002/diff/40001/src/gpu/GrInOrderDrawBuf...
src/gpu/GrInOrderDrawBuffer.cpp:530: void
GrInOrderDrawBuffer::SetState::execute(GrInOrderDrawBuffer*, const
GrOptDrawState*) { }
On 2014/11/21 22:26:24, egdaniel wrote:
> extra space in { }

Done.

https://codereview.chromium.org/746243002/diff/40001/src/gpu/GrInOrderDrawBuf...
File src/gpu/GrInOrderDrawBuffer.h (right):

https://codereview.chromium.org/746243002/diff/40001/src/gpu/GrInOrderDrawBuf...
src/gpu/GrInOrderDrawBuffer.h:220: , fState(drawState, gpu, scissor, dstCopy,
drawType) { }
On 2014/11/21 22:26:24, egdaniel wrote:
> no space :)

Done.

https://codereview.chromium.org/746243002/diff/40001/src/gpu/GrInOrderDrawBuf...
src/gpu/GrInOrderDrawBuffer.h:316: const GrOptDrawState*              
fLastState;
On 2014/11/21 22:26:24, egdaniel wrote:
> personally I like the name fPreviousState or even fCurrentState (if you tilt
> your head sideways you can kind of see it as current) better than fLastState.
> But I really don't have any negative thoughts on last so your call.

fPrevState

[bsalomon, 2014-11-24 14:37:06]

The CQ bit was checked by bsalomon@google.com

[commit-bot: I haz the power, 2014-11-24 14:37:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/746243002/60001

[commit-bot: I haz the power, 2014-11-24 14:47:53]

Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/932f8669875f5d63b8c04571931e6f4224e66e0b