Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 746243002: Create GrOptDrawState directly in the cmd buffer in GrIODB. (Closed)

Created:
6 years, 1 month ago by bsalomon
Modified:
6 years ago
Reviewers:
joshualitt, egdaniel
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@recorder
Visibility:
Public.

Description

Create GrOptDrawState directly in the cmd buffer in GrIODB. Committed: https://skia.googlesource.com/skia/+/932f8669875f5d63b8c04571931e6f4224e66e0b

Patch Set 1 #

Patch Set 2 : cleanup #

Patch Set 3 : cleanup #

Total comments: 6

Patch Set 4 : Address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -33 lines) Patch
M include/gpu/GrGpuResourceRef.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M src/gpu/GrInOrderDrawBuffer.h View 1 2 3 9 chunks +15 lines, -12 lines 0 comments Download
M src/gpu/GrInOrderDrawBuffer.cpp View 1 2 3 6 chunks +18 lines, -14 lines 0 comments Download
M src/gpu/GrOptDrawState.h View 1 chunk +1 line, -1 line 0 comments Download
M tests/GLProgramsTest.cpp View 1 chunk +3 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
bsalomon
6 years, 1 month ago (2014-11-21 18:47:50 UTC) #2
egdaniel
lgtm with minor name comment, but VERY IMPORTANT style nits https://codereview.chromium.org/746243002/diff/40001/src/gpu/GrInOrderDrawBuffer.cpp File src/gpu/GrInOrderDrawBuffer.cpp (right): https://codereview.chromium.org/746243002/diff/40001/src/gpu/GrInOrderDrawBuffer.cpp#newcode530 ...
6 years, 1 month ago (2014-11-21 22:26:24 UTC) #3
bsalomon
https://codereview.chromium.org/746243002/diff/40001/src/gpu/GrInOrderDrawBuffer.cpp File src/gpu/GrInOrderDrawBuffer.cpp (right): https://codereview.chromium.org/746243002/diff/40001/src/gpu/GrInOrderDrawBuffer.cpp#newcode530 src/gpu/GrInOrderDrawBuffer.cpp:530: void GrInOrderDrawBuffer::SetState::execute(GrInOrderDrawBuffer*, const GrOptDrawState*) { } On 2014/11/21 22:26:24, ...
6 years ago (2014-11-24 14:36:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/746243002/60001
6 years ago (2014-11-24 14:37:22 UTC) #6
commit-bot: I haz the power
6 years ago (2014-11-24 14:47:53 UTC) #7
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/932f8669875f5d63b8c04571931e6f4224e66e0b

Powered by Google App Engine
This is Rietveld 408576698