Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(692)

Issue 74623002: Remove the logic for de-duplicating in-band text track cues (Closed)

Created:
7 years, 1 month ago by philipj_slow
Modified:
7 years, 1 month ago
CC:
blink-reviews, dglazkov+blink, nessy, vcarbune.chromium, adamk+blink_chromium.org
Visibility:
Public.

Description

Remove the logic for de-duplicating in-band text track cues To de-duplicate cues by comparing their properties cannot work, since scripts can modify cues in small or big ways at any time. For example, the de-duplication will fail if the id has changed or if the timings have been slightly shifted. It must be the demuxer's responsibility to do this, e.g. by keeping track of the offsets for which cues have already been sourced. This need not consume a lot of memory, since it could record ranges of offsets. BUG=270340 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=162245

Patch Set 1 #

Patch Set 2 : WebVTTParser.cpp was moved #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -101 lines) Patch
M Source/core/html/track/InbandTextTrack.cpp View 1 1 chunk +1 line, -5 lines 0 comments Download
M Source/core/html/track/TextTrack.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/track/TextTrack.cpp View 1 1 chunk +0 lines, -58 lines 0 comments Download
M Source/core/html/track/TextTrackCue.h View 4 chunks +1 line, -10 lines 0 comments Download
M Source/core/html/track/TextTrackCue.cpp View 1 2 chunks +1 line, -26 lines 0 comments Download
M Source/core/html/track/vtt/VTTParser.cpp View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
philipj_slow
PTAL. Matthew, do you agree with my assessment that this agree can and should be ...
7 years, 1 month ago (2013-11-16 15:49:33 UTC) #1
philipj_slow
https://codereview.chromium.org/23702007/ is the review that would have to adapt to these changes.
7 years, 1 month ago (2013-11-16 15:55:29 UTC) #2
Matthew Heaney (Chromium)
lgtm
7 years, 1 month ago (2013-11-17 01:28:55 UTC) #3
philipj_slow
Adam, LGTY?
7 years, 1 month ago (2013-11-18 21:35:33 UTC) #4
adamk
lgtm rs=me for OWNERS (deferring to Matthew and Philip's judgments).
7 years, 1 month ago (2013-11-18 21:37:45 UTC) #5
adamk
Though I'm curious why this didn't affect any tests
7 years, 1 month ago (2013-11-18 21:38:09 UTC) #6
philipj_slow
On 2013/11/18 21:38:09, adamk wrote: > Though I'm curious why this didn't affect any tests ...
7 years, 1 month ago (2013-11-18 22:14:20 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/74623002/30004
7 years, 1 month ago (2013-11-18 22:20:47 UTC) #8
commit-bot: I haz the power
7 years, 1 month ago (2013-11-18 23:18:55 UTC) #9
Message was sent while issue was closed.
Change committed as 162245

Powered by Google App Engine
This is Rietveld 408576698