Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 746213002: Remove implicit conversions from scoped_refptr to T* in components/ (Closed)

Created:
6 years, 1 month ago by dcheng
Modified:
6 years, 1 month ago
Reviewers:
Lei Zhang, Sorin Jianu
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove implicit conversions from scoped_refptr to T* in components/ This patch was generated by running the rewrite_scoped_refptr clang tool on a Windows build. BUG=110610 Committed: https://crrev.com/9abb3854c75b17a68b58bc7267faae3f743c449b Cr-Commit-Position: refs/heads/master@{#305244}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -22 lines) Patch
M components/component_updater/background_downloader_win.cc View 14 chunks +18 lines, -20 lines 0 comments Download
M components/storage_monitor/volume_mount_watcher_win.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
dcheng
+sorin for component_updater, +thestig for storage_monitor
6 years, 1 month ago (2014-11-21 17:18:50 UTC) #2
Sorin Jianu
lgtm component updater lgtm Thank you Daniel!
6 years, 1 month ago (2014-11-21 17:26:18 UTC) #3
Lei Zhang
lgtm
6 years, 1 month ago (2014-11-21 17:38:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/746213002/1
6 years, 1 month ago (2014-11-21 17:40:40 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-21 18:29:15 UTC) #7
commit-bot: I haz the power
6 years, 1 month ago (2014-11-21 18:30:04 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9abb3854c75b17a68b58bc7267faae3f743c449b
Cr-Commit-Position: refs/heads/master@{#305244}

Powered by Google App Engine
This is Rietveld 408576698