Issue 746133004: Failing sky tests should not make tree red

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 746133004: Failing sky tests should not make tree red (Closed)

Created:
6 years, 1 month ago by jamesr

Modified:
6 years, 1 month ago

Reviewers:
abarth-chromium, ojan

CC:
ojan, Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, darin (slow to review), esprehn, mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Failing sky tests should not make tree red The sky tests are too unstable right now to make the buildbot red. Temporarily make a failing sky test step stay green while the underlying issues are debugged and fixed. The log and flakiness dashboard output will still reflect what actually happened during a run. TBR=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/61ee35bfd175dd1430052e91d21093979ef8db95

Patch Set 1 #

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -1 line)			Patch
	M	mojo/tools/mojob.py	View		1 chunk	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

jamesr

The tryjob here is a good example - several sky tests failed to load a ...

6 years, 1 month ago (2014-11-22 01:13:59 UTC) #3

jamesr

Committed patchset #1 (id:1) manually as 61ee35bfd175dd1430052e91d21093979ef8db95 (presubmit successful).

6 years, 1 month ago (2014-11-22 01:14:59 UTC) #4

Message was sent while issue was closed.

lgtm.

fwiw, i'm working on trying to fix the timeouts now.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages