Issue 7461126: Removing String::ToAsciiArray() since String::ToCString does a better job.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7461126: Removing String::ToAsciiArray() since String::ToCString does a better job. (Closed)

Created:
9 years, 4 months ago by Yang

Modified:
9 years, 4 months ago

Reviewers:
Erik Corry, Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Removing String::ToAsciiArray() since String::ToCString does a better job.

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -17 lines)			Patch
	M	src/objects.h	View		1 chunk	+0 lines, -2 lines	0 comments	Download
	M	src/objects-printer.cc	View		1 chunk	+0 lines, -15 lines	0 comments	Download

Total messages: 3 (0 generated)

Yang

PTAL. Removing this method again because in gdb you could just as well use call ...

9 years, 4 months ago (2011-08-04 09:01:45 UTC) #1

Erik Corry

9 years, 4 months ago (2011-08-04 09:06:42 UTC) #3

I don't like this.  The method you are deleting is 100 times easier to use from
gdb.