Fix a few lingering bugs in BrowserAccessibilityManager and BrowserAccessibilityCocoa.

content/browser/accessibility/browser_accessibility_manager.cc

Index: content/browser/accessibility/browser_accessibility_manager.cc
diff --git a/content/browser/accessibility/browser_accessibility_manager.cc b/content/browser/accessibility/browser_accessibility_manager.cc
index a99c782fc6bf1b4111f13d6ef45575869b7bd804..d7b9be9be84da983b909cffd2ab10078a0c40cee 100644
--- a/content/browser/accessibility/browser_accessibility_manager.cc
+++ b/content/browser/accessibility/browser_accessibility_manager.cc
@@ -35,6 +35,23 @@ BrowserAccessibilityManager* BrowserAccessibilityManager::Create(
 }
 #endif
 
+// static
+BrowserAccessibilityManager* BrowserAccessibilityManager::CreateEmptyDocument(
+    gfx::NativeView parent_view,
+    WebAccessibility::State state,
+    BrowserAccessibilityDelegate* delegate,
+    BrowserAccessibilityFactory* factory) {
+  // Use empty document to process notifications
+  webkit_glue::WebAccessibility empty_document;
+  // Renderer id's always start at 1000 as determined by webkit. Boot strap
+  // our ability to reuse BrowserAccessibility instances.
+  empty_document.id = 1000;
+  empty_document.role = WebAccessibility::ROLE_WEB_AREA;
+  empty_document.state = state;
+  return BrowserAccessibilityManager::Create(
+      parent_view, empty_document, delegate, factory);
+}
+
 BrowserAccessibilityManager::BrowserAccessibilityManager(
     gfx::NativeView parent_view,
     const WebAccessibility& src,
@@ -99,7 +116,10 @@ BrowserAccessibility* BrowserAccessibilityManager::GetFromRendererID(
 
 void BrowserAccessibilityManager::Remove(int32 child_id, int32 renderer_id) {
   child_id_map_.erase(child_id);
-  renderer_id_to_child_id_map_.erase(renderer_id);
+  // Make sure we don't overwrite a newer entry (see UpdateNode for a possible
+  // corner case).
+  if (renderer_id_to_child_id_map_[renderer_id] == child_id)

[Chris Guillory, 2011/08/16 02:10:31]

According to our assumptions there should not be a newer entry. We should
DCHECK(renderer_id_to_child_id_map_[renderer_id] == child_id)

+    renderer_id_to_child_id_map_.erase(renderer_id);
 }
 
 void BrowserAccessibilityManager::OnAccessibilityNotifications(
@@ -184,9 +204,8 @@ void BrowserAccessibilityManager::OnAccessibilityObjectFocusChange(
 void BrowserAccessibilityManager::OnAccessibilityObjectLoadComplete(
   const WebAccessibility& acc_obj) {
   SetFocus(NULL, false);
-  root_->InternalReleaseReference(true);
 
-  root_ = CreateAccessibilityTree(NULL, acc_obj, 0);
+  root_ = UpdateNode(acc_obj, true);

[Chris Guillory, 2011/08/16 02:10:31]

As discussed I think we do not want to use UpdateNode here. The accessibility
tree from load complete can be from a different page.

   if (!focus_)
     SetFocus(root_, false);
 
@@ -247,11 +266,13 @@ BrowserAccessibility* BrowserAccessibilityManager::GetFocus(
 
 void BrowserAccessibilityManager::SetFocus(
     BrowserAccessibility* node, bool notify) {
-  if (focus_)
-    focus_->InternalReleaseReference(false);
-  focus_ = node;
-  if (focus_)
-    focus_->InternalAddReference();
+  if (focus_ != node) {

[Chris Guillory, 2011/08/16 02:10:31]

Why are we removing this check? If focus_ equals node we shouldn't have to
perform this logic correct?

[Chris Guillory, 2011/08/16 17:25:12]

Please ignore my previous comment. For some reason I parsed this as if you were
removing this check.

+    if (focus_)
+      focus_->InternalReleaseReference(false);
+    focus_ = node;
+    if (focus_)
+      focus_->InternalAddReference();
+  }
 
   if (notify && node && delegate_)
     delegate_->SetAccessibilityFocus(node->renderer_id());
@@ -311,8 +332,7 @@ BrowserAccessibility* BrowserAccessibilityManager::UpdateNode(
   for (int i = 0; i < static_cast<int>(old_tree_nodes.size()); i++)
     old_tree_nodes[i]->InternalReleaseReference(false);
 
-  DCHECK(focus_);
-  if (!focus_->instance_active())
+  if (!focus_ || !focus_->instance_active())

[Chris Guillory, 2011/08/16 02:10:31]

We should keep the DCHECK here unless we plan to have situations occur in which
we have no focused node. I think that violates our assumptions.

     SetFocus(root_, false);
 
   return current;