Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1277)

Unified Diff: chrome/browser/ui/browser.cc

Issue 7461059: Fullscreen JS API implementation. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: remove commented out code Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/browser.cc
diff --git a/chrome/browser/ui/browser.cc b/chrome/browser/ui/browser.cc
index f54bcf50505712137a5a87b34461f1cbc9816a65..b19503566fbd203688ba289766f3c8c50bc70db0 100644
--- a/chrome/browser/ui/browser.cc
+++ b/chrome/browser/ui/browser.cc
@@ -259,7 +259,9 @@ Browser::Browser(Type type, Profile* profile)
ALLOW_THIS_IN_INITIALIZER_LIST(
synced_window_delegate_(
new BrowserSyncedWindowDelegate(this))),
- bookmark_bar_state_(BookmarkBar::HIDDEN) {
+ bookmark_bar_state_(BookmarkBar::HIDDEN),
+ fullscreened_tab_(NULL),
+ tab_caused_fullscreen_(false) {
registrar_.Add(this, content::NOTIFICATION_SSL_VISIBLE_STATE_CHANGED,
NotificationService::AllSources());
registrar_.Add(this, chrome::NOTIFICATION_EXTENSION_UPDATE_DISABLED,
@@ -1274,6 +1276,16 @@ void Browser::ShowSingletonTabOverwritingNTP(
void Browser::WindowFullscreenStateChanged() {
UpdateCommandsForFullscreenMode(window_->IsFullscreen());
UpdateBookmarkBarState(BOOKMARK_BAR_STATE_CHANGE_TOGGLE_FULLSCREEN);
+ MessageLoop::current()->PostTask(
+ FROM_HERE, method_factory_.NewRunnableMethod(
Ben Goodger (Google) 2011/08/24 18:21:49 4-space indents here
koz (OOO until 15th September) 2011/08/24 21:39:33 Done.
+ &Browser::NotifyFullscreenChange));
+}
+
+void Browser::NotifyFullscreenChange() {
+ NotificationService::current()->Notify(
+ chrome::NOTIFICATION_FULLSCREEN_CHANGED,
Ben Goodger (Google) 2011/08/24 18:21:49 and here
koz (OOO until 15th September) 2011/08/24 21:39:33 Done.
+ Source<Browser>(this),
+ NotificationService::NoDetails());
}
///////////////////////////////////////////////////////////////////////////////
@@ -1622,6 +1634,8 @@ void Browser::ConvertPopupToTabbedBrowser() {
}
void Browser::ToggleFullscreenMode() {
+ bool entering_fullscreen = !window_->IsFullscreen();
+
#if !defined(OS_MACOSX)
// In kiosk mode, we always want to be fullscreen. When the browser first
// starts we're not yet fullscreen, so let the initial toggle go through.
@@ -1631,7 +1645,7 @@ void Browser::ToggleFullscreenMode() {
#endif
UserMetrics::RecordAction(UserMetricsAction("ToggleFullscreen"));
- window_->SetFullscreen(!window_->IsFullscreen());
+ window_->SetFullscreen(entering_fullscreen);
// Once the window has become fullscreen it'll call back to
// WindowFullscreenStateChanged(). We don't do this immediately as
@@ -1643,6 +1657,16 @@ void Browser::ToggleFullscreenMode() {
#if defined(OS_MACOSX)
WindowFullscreenStateChanged();
#endif
+
+ if (!entering_fullscreen)
+ NotifyTabOfFullscreenExitIfNecessary();
+}
+
+void Browser::NotifyTabOfFullscreenExitIfNecessary() {
+ if (fullscreened_tab_)
+ fullscreened_tab_->ExitFullscreenMode();
+ fullscreened_tab_ = NULL;
+ tab_caused_fullscreen_ = false;
}
#if defined(OS_MACOSX)
@@ -2958,6 +2982,8 @@ void Browser::TabDetachedAt(TabContentsWrapper* contents, int index) {
}
void Browser::TabDeactivated(TabContentsWrapper* contents) {
+ if (contents == fullscreened_tab_)
+ ExitTabbedFullscreenModeIfNecessary();
if (instant())
instant()->DestroyPreviewContents();
@@ -3552,6 +3578,25 @@ content::JavaScriptDialogCreator* Browser::GetJavaScriptDialogCreator() {
return GetJavaScriptDialogCreatorInstance();
}
+void Browser::ToggleFullscreenModeForTab(TabContents* tab,
+ bool enter_fullscreen) {
+ if (tab != GetSelectedTabContents())
+ return;
+ fullscreened_tab_ = enter_fullscreen ?
+ TabContentsWrapper::GetCurrentWrapperForContents(tab) : NULL;
+ if (enter_fullscreen && !window_->IsFullscreen())
+ tab_caused_fullscreen_ = true;
+ if (tab_caused_fullscreen_)
+ ToggleFullscreenMode();
+}
+
+void Browser::ExitTabbedFullscreenModeIfNecessary() {
+ if (tab_caused_fullscreen_)
+ ToggleFullscreenMode();
+ else
+ NotifyTabOfFullscreenExitIfNecessary();
+}
+
///////////////////////////////////////////////////////////////////////////////
// Browser, TabContentsWrapperDelegate implementation:

Powered by Google App Engine
This is Rietveld 408576698